Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] In Harvester Installer pkg/console/install_panels.go show DNS Servers User Input within func addConfirmInstall Panel #5696

Closed
irishgordo opened this issue Apr 26, 2024 · 6 comments
Assignees
Labels
area/installer backport-needed/1.2.2 backport-needed/1.3.1 kind/enhancement Issues that improve or augment existing functionality not-require/test-plan Skip to create a e2e automation test issue
Milestone

Comments

@irishgordo
Copy link
Contributor

Is your enhancement related to a problem? Please describe.
A user, can't, at the final stage see DNS Servers that they input

Describe the solution you'd like
func addConfirmInstallPanel could possibly just show that information

Describe alternatives you've considered
A user, just "has to remember" what they input for that field...

Additional context
A user is being asked for DNS servers, or default is used, if the user inputs DNS servers, showing the user the DNS servers they input on the final panel could be beneficial for a multitude of reasons.

@irishgordo irishgordo added kind/enhancement Issues that improve or augment existing functionality area/installer labels Apr 26, 2024
irishgordo added a commit to irishgordo/harvester-installer that referenced this issue Apr 26, 2024
* if the user inputs DNS servers during the interactive ISO install they
  are then going to be shown during the confirm install panel

Resolves: feat/confirm-install-panel-show-dns-servers
See also: harvester/harvester#5696
@bk201 bk201 added this to the v1.4.0 milestone Apr 29, 2024
@harvesterhci-io-github-bot

added backport-needed/1.3.1 issue: #5702.

@harvesterhci-io-github-bot

added backport-needed/1.2.2 issue: #5703.

bk201 pushed a commit to harvester/harvester-installer that referenced this issue May 2, 2024
* if the user inputs DNS servers during the interactive ISO install they
  are then going to be shown during the confirm install panel

Resolves: feat/confirm-install-panel-show-dns-servers
See also: harvester/harvester#5696
mergify bot pushed a commit to harvester/harvester-installer that referenced this issue May 2, 2024
* if the user inputs DNS servers during the interactive ISO install they
  are then going to be shown during the confirm install panel

Resolves: feat/confirm-install-panel-show-dns-servers
See also: harvester/harvester#5696

(cherry picked from commit 305ebe0)
mergify bot pushed a commit to harvester/harvester-installer that referenced this issue May 2, 2024
* if the user inputs DNS servers during the interactive ISO install they
  are then going to be shown during the confirm install panel

Resolves: feat/confirm-install-panel-show-dns-servers
See also: harvester/harvester#5696

(cherry picked from commit 305ebe0)
bk201 pushed a commit to harvester/harvester-installer that referenced this issue May 2, 2024
* if the user inputs DNS servers during the interactive ISO install they
  are then going to be shown during the confirm install panel

Resolves: feat/confirm-install-panel-show-dns-servers
See also: harvester/harvester#5696

(cherry picked from commit 305ebe0)
bk201 pushed a commit to harvester/harvester-installer that referenced this issue May 2, 2024
* if the user inputs DNS servers during the interactive ISO install they
  are then going to be shown during the confirm install panel

Resolves: feat/confirm-install-panel-show-dns-servers
See also: harvester/harvester#5696

(cherry picked from commit 305ebe0)
@bk201 bk201 added the not-require/test-plan Skip to create a e2e automation test issue label May 2, 2024
@harvesterhci-io-github-bot
Copy link

harvesterhci-io-github-bot commented May 2, 2024

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

  • Install Harvester.
  • Add DNS servers.
  • The DNS server should display in the final review panel:
截圖 2024-05-02 晚上10 53 00
  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at:

    • Does the PR include the explanation for the fix or the feature?

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@bk201
Copy link
Member

bk201 commented May 2, 2024

@irishgordo I added a test plan and moved the issue to ready for testing. Thanks.

@noahgildersleeve
Copy link

noahgildersleeve commented May 7, 2024

I accidentally closed this when I was testing the backport issue with #5703 . So I'm marking it as ready for testing again.

@albinsun
Copy link

albinsun commented Sep 19, 2024

Test PASS, close as done.

Environment

  • harvester-v1.4.0-dev-20240918
    • Profile: Single node QEMU/KVM (8C/16G/500G)
    • ui-source: Auto

Prerequisite

  1. Manual ISO installation with DNS 1.1.1.1,8.8.8.8,9.9.9.9
    image

Steps

  1. DNS shows in the installation summary ✔️

    image

  2. DNS do configured in system ✔️

    image

QA Check List

  • Labels: not-require/test-plan, not-require/release-note, require-ui, regression...
  • Update corresponding tests ticket lables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installer backport-needed/1.2.2 backport-needed/1.3.1 kind/enhancement Issues that improve or augment existing functionality not-require/test-plan Skip to create a e2e automation test issue
Projects
None yet
Development

No branches or pull requests

5 participants