-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] In Harvester Installer pkg/console/install_panels.go
show DNS Servers User Input within func addConfirmInstall Panel
#5696
Labels
area/installer
backport-needed/1.2.2
backport-needed/1.3.1
kind/enhancement
Issues that improve or augment existing functionality
not-require/test-plan
Skip to create a e2e automation test issue
Milestone
Comments
irishgordo
added
kind/enhancement
Issues that improve or augment existing functionality
area/installer
labels
Apr 26, 2024
irishgordo
added a commit
to irishgordo/harvester-installer
that referenced
this issue
Apr 26, 2024
* if the user inputs DNS servers during the interactive ISO install they are then going to be shown during the confirm install panel Resolves: feat/confirm-install-panel-show-dns-servers See also: harvester/harvester#5696
added |
added |
bk201
pushed a commit
to harvester/harvester-installer
that referenced
this issue
May 2, 2024
* if the user inputs DNS servers during the interactive ISO install they are then going to be shown during the confirm install panel Resolves: feat/confirm-install-panel-show-dns-servers See also: harvester/harvester#5696
mergify bot
pushed a commit
to harvester/harvester-installer
that referenced
this issue
May 2, 2024
* if the user inputs DNS servers during the interactive ISO install they are then going to be shown during the confirm install panel Resolves: feat/confirm-install-panel-show-dns-servers See also: harvester/harvester#5696 (cherry picked from commit 305ebe0)
mergify bot
pushed a commit
to harvester/harvester-installer
that referenced
this issue
May 2, 2024
* if the user inputs DNS servers during the interactive ISO install they are then going to be shown during the confirm install panel Resolves: feat/confirm-install-panel-show-dns-servers See also: harvester/harvester#5696 (cherry picked from commit 305ebe0)
bk201
pushed a commit
to harvester/harvester-installer
that referenced
this issue
May 2, 2024
* if the user inputs DNS servers during the interactive ISO install they are then going to be shown during the confirm install panel Resolves: feat/confirm-install-panel-show-dns-servers See also: harvester/harvester#5696 (cherry picked from commit 305ebe0)
bk201
pushed a commit
to harvester/harvester-installer
that referenced
this issue
May 2, 2024
* if the user inputs DNS servers during the interactive ISO install they are then going to be shown during the confirm install panel Resolves: feat/confirm-install-panel-show-dns-servers See also: harvester/harvester#5696 (cherry picked from commit 305ebe0)
@irishgordo I added a test plan and moved the issue to ready for testing. Thanks. |
I accidentally closed this when I was testing the backport issue with #5703 . So I'm marking it as ready for testing again. |
Test PASS, close as done. Environment
PrerequisiteStepsQA Check List
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/installer
backport-needed/1.2.2
backport-needed/1.3.1
kind/enhancement
Issues that improve or augment existing functionality
not-require/test-plan
Skip to create a e2e automation test issue
Is your enhancement related to a problem? Please describe.
A user, can't, at the final stage see DNS Servers that they input
Describe the solution you'd like
func addConfirmInstallPanel
could possibly just show that informationDescribe alternatives you've considered
A user, just "has to remember" what they input for that field...
Additional context
A user is being asked for DNS servers, or default is used, if the user inputs DNS servers, showing the user the DNS servers they input on the final panel could be beneficial for a multitude of reasons.
The text was updated successfully, but these errors were encountered: