feat(controller): support vmnetcfg disabled mode #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an VirtualMachineNetworkConfig is disabled, it will free up the slot it occupied in IPAM and remove the MAC cache entry. Also, the referencing IPPool's status will be updated. However, the allocation record still remain on its status field. When the VirtualMachineNetworkConfig is enabled again, the same IP address will be allocated. Signed-off-by: Zespre Chang <zespre.chang@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a VirtualMachineNetworkConfig is disabled, it will free up the slot occupied in IPAM and remove the MAC cache entry. Also, the referencing IPPool's status will be updated. However, the allocation record remains on its status field. When the VirtualMachineNetworkConfig is enabled again, the same IP address will be allocated.