Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

free_y ignored with facet_grid('. ~ var'), but works with facet_grid('var ~ .') and facet_wrap() #58

Closed
jdanbrown opened this issue Sep 20, 2017 · 1 comment
Closed

free_y ignored with facet_grid('. ~ var'), but works with facet_grid('var ~ .') and facet_wrap() #58

jdanbrown opened this issue Sep 20, 2017 · 1 comment
Labels
bug

Comments

@jdanbrown
Copy link
Contributor 

df = pd.DataFrame({'x': np.random.rand(100), 'y': np.random.rand(100)})
df['color'] = np.floor(df['y'] * 3).astype('str')
# Bad: free_y ignored
ggplot(df, aes('x', 'y', color='color')) + geom_point() + facet_grid('. ~ color', scales='free_y')

image

# Good
ggplot(df, aes('x', 'y', color='color')) + geom_point() + facet_grid('color ~ .', scales='free_y')

image

# Good
ggplot(df, aes('x', 'y', color='color')) + geom_point() + facet_wrap('color', scales='free_y')

image
@has2k1 has2k1 added the bug label Sep 20, 2017
has2k1 added a commit that referenced this issue Sep 21, 2017
@has2k1
Fix facet_grid, handlind of free_x|y scales
549666e 
Some of the lines reponsible for this functionality have been changed
to match those in `facet_wrap`. I don't know why they diverged in the
first place.

fixes #58
@has2k1 has2k1 closed this as completed in 119d9b8 Sep 21, 2017
@jdanbrown
Copy link
Contributor Author

🎉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdanbrown @has2k1