fix: resolves the accidental mangling of Helm subchart versions on release #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… release Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
nathanklick
added
the
Bug
nathanklick
requested review from
jeromy-cannon,
leninmehedy and
deepak-swirlds
leninmehedy
approved these changes
Aug 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
swirlds-automation
added a commit
that referenced
this pull request
Sep 14, 2023
## [0.8.0](v0.7.0...v0.8.0) (2023-09-14) ### Features * add hedera node explorer as a conditional sub chart ([#275](#275)) ([c4eb8d7](c4eb8d7)) * add helm chart tests to check haproxy and envoy proxy deployments ([#319](#319)) ([08c3f85](08c3f85)) * add helm chart tests to validate state of sidecars ([#314](#314)) ([e04de57](e04de57)) * add optional Gateway API resource definition to expose endpoints ([#280](#280)) ([9b9effd](9b9effd)) * allow pod-monitor-role to have access to secrets ([#309](#309)) ([75e66c3](75e66c3)) * convert helm client test source set to a module ([#300](#300)) ([2fcb3c3](2fcb3c3)) * enable locally building and loading kubectl-bats docker image into the cluster for helm tests ([#310](#310)) ([230b291](230b291)) * ensure OTel collector is able to export metrics and traces ([#298](#298)) ([8c24733](8c24733)) * expose envoy-proxy prometheus metrics endpoint ([#328](#328)) ([f052481](f052481)) * expose prometheus metrics from HAProxy ([#320](#320)) ([8d4f51c](8d4f51c)) * introduces the build-logic project instead of buildSrc ([#327](#327)) ([aeb4c48](aeb4c48)) * parameterize gateway port mapping using values file ([#339](#339)) ([0c16855](0c16855)) * support higher number of nodes with consistent gateway port mapping ([#337](#337)) ([8b44410](8b44410)) * switch from JPMS module conventions to project level plugin ([#312](#312)) ([b3a7429](b3a7429)) * update Open Telemetry configuration to support optional remote write pushing of metrics and log ([#281](#281)) ([f5aadc5](f5aadc5)) ### Bug Fixes * lock the semantic release toolchain to specific known working versions ([#342](#342)) ([5eb8600](5eb8600)) * resolves the accidental mangling of Helm subchart versions on release ([#285](#285)) ([4e6a539](4e6a539)) * use 9090 as prometheus port across services for consistency ([#330](#330)) ([5052945](5052945))
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jeromy-cannon
pushed a commit
that referenced
this pull request
Sep 14, 2023
…lease (#285) Signed-off-by: Nathan Klick <nathan@swirldslabs.com> Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
jeromy-cannon
pushed a commit
that referenced
this pull request
Sep 14, 2023
## [0.8.0](v0.7.0...v0.8.0) (2023-09-14) ### Features * add hedera node explorer as a conditional sub chart ([#275](#275)) ([c4eb8d7](c4eb8d7)) * add helm chart tests to check haproxy and envoy proxy deployments ([#319](#319)) ([08c3f85](08c3f85)) * add helm chart tests to validate state of sidecars ([#314](#314)) ([e04de57](e04de57)) * add optional Gateway API resource definition to expose endpoints ([#280](#280)) ([9b9effd](9b9effd)) * allow pod-monitor-role to have access to secrets ([#309](#309)) ([75e66c3](75e66c3)) * convert helm client test source set to a module ([#300](#300)) ([2fcb3c3](2fcb3c3)) * enable locally building and loading kubectl-bats docker image into the cluster for helm tests ([#310](#310)) ([230b291](230b291)) * ensure OTel collector is able to export metrics and traces ([#298](#298)) ([8c24733](8c24733)) * expose envoy-proxy prometheus metrics endpoint ([#328](#328)) ([f052481](f052481)) * expose prometheus metrics from HAProxy ([#320](#320)) ([8d4f51c](8d4f51c)) * introduces the build-logic project instead of buildSrc ([#327](#327)) ([aeb4c48](aeb4c48)) * parameterize gateway port mapping using values file ([#339](#339)) ([0c16855](0c16855)) * support higher number of nodes with consistent gateway port mapping ([#337](#337)) ([8b44410](8b44410)) * switch from JPMS module conventions to project level plugin ([#312](#312)) ([b3a7429](b3a7429)) * update Open Telemetry configuration to support optional remote write pushing of metrics and log ([#281](#281)) ([f5aadc5](f5aadc5)) ### Bug Fixes * lock the semantic release toolchain to specific known working versions ([#342](#342)) ([5eb8600](5eb8600)) * resolves the accidental mangling of Helm subchart versions on release ([#285](#285)) ([4e6a539](4e6a539)) * use 9090 as prometheus port across services for consistency ([#330](#330)) ([5052945](5052945)) Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
versionAsSpecifiedtasks incorrectly ignoring leading whitespace when updating the chart versions.Related Issues