Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase cohesion between koa and koaJsonRpc #530

Closed
georgi-l95 opened this issue Sep 17, 2022 · 0 comments · Fixed by #580
Closed

Increase cohesion between koa and koaJsonRpc #530

georgi-l95 opened this issue Sep 17, 2022 · 0 comments · Fixed by #580
Assignees
Labels
enhancement New feature or request limechain P2
Milestone

Comments

@georgi-l95
Copy link
Collaborator

Problem

Koa and KoaJsonRpc logic is separated in server, which makes for harder debugging, because of the increased coupling. With the rate limit we introduced custom json rpc, which can be combined with koa for increased cohesion.

Solution

Look for way to combine koa and jsonrpc in one class.

Alternatives

No response

@georgi-l95 georgi-l95 added enhancement New feature or request limechain labels Sep 17, 2022
@georgi-l95 georgi-l95 self-assigned this Sep 17, 2022
@georgi-l95 georgi-l95 mentioned this issue Sep 17, 2022
2 tasks
@Nana-EC Nana-EC added this to the 0.10 milestone Sep 26, 2022
@georgi-l95 georgi-l95 linked a pull request Oct 3, 2022 that will close this issue
2 tasks
@Nana-EC Nana-EC added the P2 label Oct 3, 2022
@Nana-EC Nana-EC modified the milestones: 0.10, 0.9.0 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limechain P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants