Improve Koa and KoaJsonRpc classes #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 72.02% // Head: 72.02% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #580 +/- ##
=======================================
Coverage 72.02% 72.02%
=======================================
Files 15 15
Lines 1026 1026
Branches 166 166
=======================================
Hits 739 739
Misses 236 236
Partials 51 51 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Nana-EC
previously approved these changes
Oct 3, 2022
Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95
force-pushed
the
530-increase-cohesion-between-koa-and-koajsonrpc
branch
from
5ad4c60
to
b823326
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
georgi-l95
deleted the
530-increase-cohesion-between-koa-and-koajsonrpc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: georgi-l95 glazarov95@gmail.com
Description:
Initialise Koa server in Koa Json RPC class, no need to be separate.
Related issue(s):
Fixes #530
Notes for reviewer:
Checklist