-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change units of the value in eth gettransactionbyhash result #3080
feat: change units of the value in eth gettransactionbyhash result #3080
Conversation
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: MarkSweepCompact Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously approved, but now in the repository feature branch.
dda4ead
to
9898aeb
Compare
Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
9898aeb
to
84c4102
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3080 +/- ##
=======================================
Coverage 84.84% 84.84%
=======================================
Files 59 59
Lines 3939 3939
Branches 788 788
=======================================
Hits 3342 3342
Misses 359 359
Partials 238 238
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…3080) * fix: change unit of transaction value result Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> * chore: reusable tinybarsToWeibars method and tests Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> --------- Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> Co-authored-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
…3080) * fix: change unit of transaction value result Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> * chore: reusable tinybarsToWeibars method and tests Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> --------- Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> Co-authored-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> Signed-off-by: ebadiere <ebadiere@gmail.com>
#3081) feat: change units of the value in eth gettransactionbyhash result (#3080) * fix: change unit of transaction value result * chore: reusable tinybarsToWeibars method and tests --------- Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> Signed-off-by: ebadiere <ebadiere@gmail.com> Co-authored-by: Nadezhda Popova <48063261+nadezhdapopovaa@users.noreply.github.com> Co-authored-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
…3080) * fix: change unit of transaction value result Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> * chore: reusable tinybarsToWeibars method and tests Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> --------- Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local> Co-authored-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Description:
Convert value of a transaction from tinybars to weibars for consistency.
Related issue(s):
Fixes #3053
Notes for reviewer:
Checklist