Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change units of the value in eth gettransactionbyhash result #3080

Conversation

nadezhdapopovaa
Copy link
Contributor

Description:

Convert value of a transaction from tinybars to weibars for consistency.

Related issue(s):

Fixes #3053

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@nadezhdapopovaa nadezhdapopovaa linked an issue Oct 9, 2024 that may be closed by this pull request
@natanasow natanasow changed the title 3053 change units of the value in eth gettransactionbyhash result feat: change units of the value in eth gettransactionbyhash result Oct 9, 2024
@natanasow natanasow added this to the 0.58.0 milestone Oct 9, 2024
@natanasow natanasow added the enhancement New feature or request label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 30,025.6 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 1.72 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: decreased with 344.06 KB
  • Total Available Size: increased with 2.23 MB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 64.00 bytes
  • Used Heap Size: decreased with 3.28 MB
  • Heap Size Limit: no changes
  • Malloced Memory: no changes
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • Old Space:

    • Space Size: increased with 2.10 MB
    • Space Used Size: increased with 2.09 MB
    • Space Available Size: decreased with 365.87 KB
    • Physical Space Size: increased with 2.10 MB
  • Large Object Space:

    • Space Size: increased with 835.58 KB
    • Space Used Size: increased with 813.50 KB
    • Space Available Size: no changes
    • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

Copy link

github-actions bot commented Oct 9, 2024

Tests

       3 files     300 suites   19s ⏱️
1 359 tests 1 358 ✔️ 1 💤 0
1 368 runs  1 367 ✔️ 1 💤 0

Results for commit 84c4102.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 9, 2024

Acceptance Tests

  17 files  240 suites   29m 23s ⏱️
603 tests 598 ✔️ 4 💤 1
708 runs  703 ✔️ 4 💤 1

Results for commit 84c4102.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously approved, but now in the repository feature branch.

@nadezhdapopovaa nadezhdapopovaa force-pushed the 3053-change-units-of-the-value-in-eth_gettransactionbyhash-result branch from dda4ead to 9898aeb Compare October 9, 2024 15:23
Nadezhda Popova added 2 commits October 9, 2024 18:30
Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
@nadezhdapopovaa nadezhdapopovaa force-pushed the 3053-change-units-of-the-value-in-eth_gettransactionbyhash-result branch from 9898aeb to 84c4102 Compare October 9, 2024 15:30
Copy link

sonarcloud bot commented Oct 9, 2024

@ebadiere ebadiere merged commit dbe5fc5 into main Oct 9, 2024
43 checks passed
@ebadiere ebadiere deleted the 3053-change-units-of-the-value-in-eth_gettransactionbyhash-result branch October 9, 2024 16:05
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (670e5fa) to head (84c4102).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3080   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files          59       59           
  Lines        3939     3939           
  Branches      788      788           
=======================================
  Hits         3342     3342           
  Misses        359      359           
  Partials      238      238           
Flag Coverage Δ
relay 84.95% <ø> (ø)
server 83.43% <ø> (ø)
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/constants.ts 92.00% <ø> (ø)

ebadiere pushed a commit that referenced this pull request Oct 9, 2024
…3080)

* fix: change unit of transaction value result

Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>

* chore: reusable tinybarsToWeibars method and tests

Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>

---------

Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Co-authored-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
ebadiere pushed a commit that referenced this pull request Oct 9, 2024
…3080)

* fix: change unit of transaction value result

Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>

* chore: reusable tinybarsToWeibars method and tests

Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>

---------

Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Co-authored-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere added a commit that referenced this pull request Oct 9, 2024
#3081)

feat: change units of the value in eth gettransactionbyhash result (#3080)

* fix: change unit of transaction value result



* chore: reusable tinybarsToWeibars method and tests



---------

Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Co-authored-by: Nadezhda Popova <48063261+nadezhdapopovaa@users.noreply.github.com>
Co-authored-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
konstantinabl pushed a commit that referenced this pull request Oct 15, 2024
…3080)

* fix: change unit of transaction value result

Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>

* chore: reusable tinybarsToWeibars method and tests

Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>

---------

Signed-off-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Co-authored-by: Nadezhda Popova <nadezhdapopova@Nadezhdas-Work-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change units of the value in eth_getTransactionByHash result
4 participants