-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configmap fix env from change #767
Conversation
…ailed rollouts, I believe we are hitting this issue - kubernetes/kubernetes#46861. The TL;DR is that due to yaml to json conversion all ENVs need to be quoted or they cause failures to be seen. Boolean and ints both need to be quoted along with strings; this issue was open in 2017 and still getting comments Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
… stated here https://github.com/hashgraph/hedera-json-rpc-relay/pull/522\#discussion_r971487256 Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
…t that are used to set ENVs. This change should make future ENVs additions simpler Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportBase: 72.87% // Head: 72.89% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
==========================================
+ Coverage 72.87% 72.89% +0.02%
==========================================
Files 16 16
Lines 1246 1247 +1
Branches 231 232 +1
==========================================
+ Hits 908 909 +1
Misses 280 280
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
DEV_MODE: {{ .Values.config.DEV_MODE | quote }} | ||
MIRROR_NODE_RETRIES: {{ .Values.config.MIRROR_NODE_RETRIES | quote }} | ||
MIRROR_NODE_RETRY_DELAY: {{ .Values.config.MIRROR_NODE_RETRY_DELAY | quote }} | ||
MIRROR_NODE_LIMIT_PARAM: {{ .Values.config.MIRROR_NODE_LIMIT_PARAM | quote }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add CLIENT_TRANSPORT_SECURITY
seems it was missed when added in previous PRs
MIRROR_NODE_LIMIT_PARAM: {{ .Values.config.MIRROR_NODE_LIMIT_PARAM | quote }} | |
MIRROR_NODE_LIMIT_PARAM: {{ .Values.config.MIRROR_NODE_LIMIT_PARAM | quote }} | |
CLIENT_TRANSPORT_SECURITY: {{ .Values.config.CLIENT_TRANSPORT_SECURITY | quote }} |
Description:
This PR modifies
[debug] ConfigMap in version "v1" cannot be handled as a ConfigMap: v1.ConfigMap.Data: ReadString: expects " or n, but found 2, error found in
andkubectl apply -f templates/test.yaml The Deployment "test" is invalid: spec.template.spec.containers[0].env[15].valueFrom: Invalid value: "": may not be specified when
valueis not empty
. Both of these error occurrence suggest that quoting values is needed for the pods to accept them correctly. Here is one of the issues being referenced.Notes for reviewer:
WIP - rollout testing will happen 2022-12-13 and 2022-12-14
Checklist