Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Helm templating for proxyPass value #725

Closed
leninmehedy opened this issue Oct 16, 2023 · 0 comments · Fixed by #726
Closed

Allow Helm templating for proxyPass value #725

leninmehedy opened this issue Oct 16, 2023 · 0 comments · Fixed by #726
Assignees
Labels
enhancement New feature or request

Comments

@leninmehedy
Copy link
Member

leninmehedy commented Oct 16, 2023

Problem

Recently added proxyPass variable does not support templating, which requires hardcoding the value in the values.yaml file or use --set command to set it explicitly as http://<RELEASE_NAME>-rest.

However, it would have been better if the value could be set as template, e.g. http://{{ .Release.Name }}-fst.

Relevant issue: hashgraph/full-stack-testing#410

Solution

  • Allow proxyPass value to be a template e.g. http://{{ .Release.Name }}-fst.
  • Use tpl function to render the template while creating the configmap here

Alternatives

Without supporting the templating, end-user always needs to update the values.yaml file or use --set hedera-explorer:.proxyPass=<NEW VALUE> during deployment of their chart with a new release name.

Blocks

@leninmehedy leninmehedy added the enhancement New feature or request label Oct 16, 2023
@leninmehedy leninmehedy self-assigned this Oct 16, 2023
leninmehedy added a commit that referenced this issue Oct 16, 2023
@leninmehedy leninmehedy linked a pull request Oct 16, 2023 that will close this issue
2 tasks
leninmehedy added a commit that referenced this issue Oct 16, 2023
Closes #725

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant