Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unit tests for SearchRequest now validates MockAdaptor history. #1135

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ericleponner
Copy link
Collaborator

@ericleponner ericleponner commented Jun 18, 2024

Description:

Changes below improve unit tests for SearchRequest class.
They don't include any semantic changes.

Each test now verifies REST urls invoked by SearchRequest.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…s history urls).

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.06% 40127 / 48309
🔵 Statements 83.06% 40127 / 48309
🔵 Functions 62.76% 902 / 1437
🔵 Branches 84.06% 4188 / 4982
File CoverageNo changed files found.
Generated in workflow #1024

Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
7.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ericleponner ericleponner merged commit 9a6a3e7 into main Jun 18, 2024
7 of 8 checks passed
@ericleponner ericleponner deleted the search_request_unit_test branch June 18, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants