Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow default ContractIDs #13438

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: allow default ContractIDs #13438

merged 1 commit into from
May 28, 2024

Conversation

tinker-michaelj
Copy link
Collaborator

Description:

@tinker-michaelj
fix: allow default ContractIDs (#13421)
bc59433 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested review from a team as code owners May 21, 2024 17:34
@github-actions GitHub Actions
Copy link

Node: HAPI Test (Restart) Results

2 tests   2 ✔️  5m 23s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit bc59433.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✔️  6m 59s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit bc59433.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Token) Results

228 tests   227 ✔️  20m 42s ⏱️
  16 suites      1 💤
  16 files        0 ❌

Results for commit bc59433.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Crypto) Results

230 tests   230 ✔️  25m 39s ⏱️
  23 suites      0 💤
  23 files        0 ❌

Results for commit bc59433.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✔️  54m 5s ⏱️
  3 suites    0 💤
  3 files      0 ❌

Results for commit bc59433.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Smart Contract) Results

515 tests   509 ✔️  1h 5m 42s ⏱️
  56 suites      3 💤
  56 files        3 ❌

For more details on these failures, see this check.

Results for commit bc59433.

@github-actions GitHub Actions
Copy link

Node: Unit Test Results

    2 267 files  ±0      2 267 suites  ±0   3h 53m 6s ⏱️ + 1h 30m 28s
112 221 tests +1  112 166 ✔️ +2  55 💤 ±0  0 ❌  - 1 
120 683 runs  +1  120 628 ✔️ +2  55 💤 ±0  0 ❌  - 1 

Results for commit bc59433. ± Comparison against base commit 0995745.

david-bakin-sl
david-bakin-sl approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherry pick LGTM

@tinker-michaelj tinker-michaelj merged commit 773d99d into release/0.49 May 28, 2024
45 of 50 checks passed
@tinker-michaelj tinker-michaelj deleted the cherry-pick-13421 branch May 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimbor kimbor kimbor approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@david-bakin-sl david-bakin-sl david-bakin-sl approved these changes

@jasperpotts jasperpotts Awaiting requested review from jasperpotts jasperpotts is a code owner automatically assigned from hashgraph/hedera-base

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tinker-michaelj @kimbor @Neeharika-Sompalli @david-bakin-sl