feat: require admin key for maxAutoAssociations during contractUpdate #14161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>
Node: Unit Test Results 1 545 files 1 545 suites 3h 30m 19s ⏱️ Results for commit 5e91d09. |
Node: HAPI Test (Restart) Results3 tests 3 ✅ 2m 59s ⏱️ Results for commit 5e91d09. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results3 tests 3 ✅ 6m 39s ⏱️ Results for commit 5e91d09. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results 22 files 22 suites 6m 31s ⏱️ Results for commit 5e91d09. |
Node: HAPI Test (Crypto) Results 24 files 24 suites 12m 20s ⏱️ Results for commit 5e91d09. |
Node: HAPI Test (Misc) Results 51 files 51 suites 21m 13s ⏱️ Results for commit 5e91d09. |
Node: HAPI Test (Smart Contract) Results 73 files 73 suites 22m 38s ⏱️ Results for commit 5e91d09. |
Node: HAPI Test (Time Consuming) Results19 tests 19 ✅ 29m 18s ⏱️ Results for commit 5e91d09. |
netopyr
added a commit
that referenced
this pull request
Jul 18, 2024
* develop: (528 commits) chore: Remove unused script (#14266) feat: use platform event post consensus (#14256) chore: Removed allowances modification on `TokenReject` (#14282) chore: Added newlines to property-files (#14275) test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267) fix: node remove test (#14237) feat: Add new pbj event hasher (#14226) chore: updated perf nightly workflow (#14263) docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558) feat: hapi tests for DAB createNode (#14228) feat(reconnect): log ReconnectMapStats (#14250) chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232) chore: Made StakingValidator static (#14159) feat: require admin key for maxAutoAssociations during contractUpdate (#14161) build: filter publishing by deactivating tasks (develop) (#14187) docs: Extend design doc for HIP-719 (#14212) feat: add isAssociated system contract (#14169) chore: File Service compiler warning fixes (#14216) fix: Fix casting exception for event-stream recover (#14055) feat: hashgraph GUI fixes (#14060) ... # Conflicts: # hapi/build.gradle.kts # hapi/src/main/java/com/hedera/hapi/util/HapiUtils.java # hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ApiPermissionConfig.java # hedera-node/hedera-mono-service/src/main/java/com/hedera/node/app/service/mono/pbj/PbjConverter.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/TxnFactory.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenCreate.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenUpdate.java
netopyr
added a commit
that referenced
this pull request
Jul 19, 2024
* develop: (22 commits) ci: stop release 0.51 regression (#14290) refactor: 14230 Removed `uptimeData` feature. (#14231) chore: HAPI cloneHederaProtobufs back to main (#14298) feat: HIP-850: HTS mutable metadata in treasury (#14204) chore: Remove unused script (#14266) feat: use platform event post consensus (#14256) chore: Removed allowances modification on `TokenReject` (#14282) chore: Added newlines to property-files (#14275) test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267) fix: node remove test (#14237) feat: Add new pbj event hasher (#14226) chore: updated perf nightly workflow (#14263) docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558) feat: hapi tests for DAB createNode (#14228) feat(reconnect): log ReconnectMapStats (#14250) chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232) chore: Made StakingValidator static (#14159) feat: require admin key for maxAutoAssociations during contractUpdate (#14161) build: filter publishing by deactivating tasks (develop) (#14187) docs: Extend design doc for HIP-719 (#14212) ... # Conflicts: # hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/api/TokenServiceApiProvider.java # hedera-node/hedera-token-service-impl/src/test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoDeleteHandlerTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Require admin key for maxAutoAssociations during contractUpdate
Related issue(s):
Fixes #14111
Notes for reviewer:
Checklist