feat: HIP-850: HTS mutable metadata in treasury #14204

derektriley · 2024-07-10T13:02:26Z

Description:

This PR implements the functionality required for HIP-850
Enhancing Supply Key Functionality for NFT Updates in Treasury Account. Specifically enabling the Supply Key to update an NFT metadata field while the NFT is held in the treasury account

See hashgraph/hedera-protobufs#394
for protobuf changes (new ResponseCodeEnum value).

Fixes #14109

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

github-actions · 2024-07-10T13:15:14Z

Node: Unit Test Results

1 531 files 1 531 suites 2h 47m 11s ⏱️
115 818 tests 115 759 ✅ 59 💤 0 ❌
124 026 runs 123 967 ✅ 59 💤 0 ❌

Results for commit f1e0f24.

♻️ This comment has been updated with latest results.

codecov · 2024-07-10T13:16:13Z

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.62%. Comparing base (9973fae) to head (f1e0f24).
Report is 140 commits behind head on develop.

Files	Patch %	Lines
...ce/token/impl/handlers/TokenUpdateNftsHandler.java	90.47%	0 Missing and 2 partials ⚠️
...edera/node/app/hapi/utils/CommonPbjConverters.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #14204      +/-   ##
=============================================
- Coverage      67.58%   57.62%   -9.97%     
+ Complexity     36486    21886   -14600     
=============================================
  Files           3732     2853     -879     
  Lines         149767   109870   -39897     
  Branches       15571    11257    -4314     
=============================================
- Hits          101223    63313   -37910     
+ Misses         44179    42977    -1202     
+ Partials        4365     3580     -785

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-07-10T13:17:00Z

Node: HAPI Test (Node Death Reconnect) Results

3 tests 3 ✅ 5m 38s ⏱️
3 suites 0 💤
3 files 0 ❌

Results for commit f1e0f24.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-10T13:17:26Z

Node: HAPI Test (Token) Results

22 files 22 suites 6m 16s ⏱️
281 tests 281 ✅ 0 💤 0 ❌
360 runs 360 ✅ 0 💤 0 ❌

Results for commit f1e0f24.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-10T13:18:35Z

Node: HAPI Test (Restart) Results

7 files 7 suites 8m 29s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs 7 ✅ 0 💤 0 ❌

Results for commit f1e0f24.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-10T13:24:42Z

Node: HAPI Test (Crypto) Results

24 files 24 suites 14m 21s ⏱️
347 tests 347 ✅ 0 💤 0 ❌
372 runs 372 ✅ 0 💤 0 ❌

Results for commit f1e0f24.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-10T13:32:05Z

Node: HAPI Test (Misc) Results

59 files 59 suites 16m 52s ⏱️
316 tests 316 ✅ 0 💤 0 ❌
391 runs 391 ✅ 0 💤 0 ❌

Results for commit f1e0f24.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-10T13:34:23Z

Node: HAPI Test (Time Consuming) Results

19 tests 19 ✅ 22m 40s ⏱️
4 suites 0 💤
4 files 0 ❌

Results for commit f1e0f24.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-10T13:35:24Z

Node: HAPI Test (Smart Contract) Results

82 files 82 suites 24m 32s ⏱️
649 tests 649 ✅ 0 💤 0 ❌
759 runs 759 ✅ 0 💤 0 ❌

Results for commit f1e0f24.

♻️ This comment has been updated with latest results.

Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>

mhess-swl

For the unit tests, using subject.preHandle(preHandleContext)).doesNotThrowAnyException(); doesn't seem sufficient, especially when preHandleContext is a mock

...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java

...st/java/com/hedera/node/app/service/token/impl/test/handlers/TokenUpdateNftsHandlerTest.java

...de/test-clients/src/main/java/com/hedera/services/bdd/suites/token/TokenUpdateNftsSuite.java

...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java

...de/test-clients/src/main/java/com/hedera/services/bdd/suites/token/TokenUpdateNftsSuite.java

Neeharika-Sompalli

Great work @derektriley 🙌 ! Overall Looks good. Have some comments.

… tests Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>

Neeharika-Sompalli

LGTM ! Thanks @derektriley 🙌

...de/test-clients/src/main/java/com/hedera/services/bdd/suites/token/TokenUpdateNftsSuite.java

Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>

Neeharika-Sompalli

LGTM! Thanks @derektriley

* develop: (22 commits) ci: stop release 0.51 regression (#14290) refactor: 14230 Removed `uptimeData` feature. (#14231) chore: HAPI cloneHederaProtobufs back to main (#14298) feat: HIP-850: HTS mutable metadata in treasury (#14204) chore: Remove unused script (#14266) feat: use platform event post consensus (#14256) chore: Removed allowances modification on `TokenReject` (#14282) chore: Added newlines to property-files (#14275) test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267) fix: node remove test (#14237) feat: Add new pbj event hasher (#14226) chore: updated perf nightly workflow (#14263) docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558) feat: hapi tests for DAB createNode (#14228) feat(reconnect): log ReconnectMapStats (#14250) chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232) chore: Made StakingValidator static (#14159) feat: require admin key for maxAutoAssociations during contractUpdate (#14161) build: filter publishing by deactivating tasks (develop) (#14187) docs: Extend design doc for HIP-719 (#14212) ... # Conflicts: # hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/api/TokenServiceApiProvider.java # hedera-node/hedera-token-service-impl/src/test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoDeleteHandlerTest.java

derektriley added this to the v0.53 milestone Jul 10, 2024

derektriley self-assigned this Jul 10, 2024

derektriley requested review from a team as code owners July 10, 2024 13:02

derektriley requested review from rbair23 and povolev15 July 10, 2024 13:02

derektriley linked an issue Jul 10, 2024 that may be closed by this pull request

HTS mutable metadata in treasury #14109

Closed

derektriley marked this pull request as draft July 10, 2024 13:21

derektriley added 4 commits July 10, 2024 09:47

wip

076c3f0

Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>

HIP-850 Supply Key Functionality for NFT Metadata Updates

93493e0

Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>

Added tests

640910a

Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>

Test coverage

f6e1534

Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>

derektriley force-pushed the 14109-hts-mutable-metadata-in-treasury branch from b923b85 to f6e1534 Compare July 10, 2024 13:47

UpdateNftsHandler variable decl

471c975

Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>

derektriley marked this pull request as ready for review July 10, 2024 15:16

mhess-swl reviewed Jul 10, 2024

View reviewed changes

Neeharika-Sompalli reviewed Jul 11, 2024

View reviewed changes

...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java Outdated Show resolved Hide resolved

Neeharika-Sompalli reviewed Jul 11, 2024

View reviewed changes

...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java Outdated Show resolved Hide resolved

Neeharika-Sompalli reviewed Jul 11, 2024

View reviewed changes

...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java Outdated Show resolved Hide resolved

Neeharika-Sompalli reviewed Jul 11, 2024

View reviewed changes

...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java Show resolved Hide resolved

Neeharika-Sompalli reviewed Jul 11, 2024

View reviewed changes

...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java Outdated Show resolved Hide resolved

Neeharika-Sompalli reviewed Jul 11, 2024

View reviewed changes

...de/test-clients/src/main/java/com/hedera/services/bdd/suites/token/TokenUpdateNftsSuite.java Show resolved Hide resolved

Neeharika-Sompalli reviewed Jul 11, 2024

View reviewed changes

Added usage of new ResponseCode in TokenUpdateNftsHandler, updates to…

a68407a

… tests Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>

derektriley requested a review from a team as a code owner July 11, 2024 15:16

derektriley requested a review from rbarkerSL July 11, 2024 15:16

derektriley mentioned this pull request Jul 11, 2024

feat: HIP-850: HTS mutable metadata in treasury hashgraph/hedera-protobufs#394

Merged

2 tasks

Neeharika-Sompalli previously approved these changes Jul 11, 2024

View reviewed changes

...de/test-clients/src/main/java/com/hedera/services/bdd/suites/token/TokenUpdateNftsSuite.java Outdated Show resolved Hide resolved

Update test name

f1e0f24

Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>

derektriley dismissed Neeharika-Sompalli’s stale review via f1e0f24 July 15, 2024 15:27

Neeharika-Sompalli approved these changes Jul 15, 2024

View reviewed changes

rbarkerSL approved these changes Jul 15, 2024

View reviewed changes

derektriley merged commit e386407 into develop Jul 18, 2024
41 of 43 checks passed

derektriley deleted the 14109-hts-mutable-metadata-in-treasury branch July 18, 2024 13:19

derektriley mentioned this pull request Aug 5, 2024

fix: TokenUpdateNftsHandler throwing HandleException in preHandle #14600

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: HIP-850: HTS mutable metadata in treasury #14204

feat: HIP-850: HTS mutable metadata in treasury #14204

derektriley commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

codecov bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

mhess-swl left a comment

Neeharika-Sompalli left a comment •

edited

Loading

Neeharika-Sompalli left a comment

Neeharika-Sompalli left a comment

feat: HIP-850: HTS mutable metadata in treasury #14204

feat: HIP-850: HTS mutable metadata in treasury #14204

Conversation

derektriley commented Jul 10, 2024 • edited Loading

github-actions bot commented Jul 10, 2024 • edited Loading

Node: Unit Test Results

codecov bot commented Jul 10, 2024 • edited Loading

Codecov Report

github-actions bot commented Jul 10, 2024 • edited Loading

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented Jul 10, 2024 • edited Loading

Node: HAPI Test (Token) Results

github-actions bot commented Jul 10, 2024 • edited Loading

Node: HAPI Test (Restart) Results

github-actions bot commented Jul 10, 2024 • edited Loading

Node: HAPI Test (Crypto) Results

github-actions bot commented Jul 10, 2024 • edited Loading

Node: HAPI Test (Misc) Results

github-actions bot commented Jul 10, 2024 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Jul 10, 2024 • edited Loading

Node: HAPI Test (Smart Contract) Results

mhess-swl left a comment

Choose a reason for hiding this comment

Neeharika-Sompalli left a comment • edited Loading

Choose a reason for hiding this comment

Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

derektriley commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

codecov bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

github-actions bot commented Jul 10, 2024 •

edited

Loading

Neeharika-Sompalli left a comment •

edited

Loading