-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HIP-850: HTS mutable metadata in treasury #14204
Conversation
Node: Unit Test Results 1 531 files 1 531 suites 2h 47m 11s ⏱️ Results for commit f1e0f24. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14204 +/- ##
=============================================
- Coverage 67.58% 57.62% -9.97%
+ Complexity 36486 21886 -14600
=============================================
Files 3732 2853 -879
Lines 149767 109870 -39897
Branches 15571 11257 -4314
=============================================
- Hits 101223 63313 -37910
+ Misses 44179 42977 -1202
+ Partials 4365 3580 -785 ☔ View full report in Codecov by Sentry. |
Node: HAPI Test (Node Death Reconnect) Results3 tests 3 ✅ 5m 38s ⏱️ Results for commit f1e0f24. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results 22 files 22 suites 6m 16s ⏱️ Results for commit f1e0f24. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Restart) Results7 files 7 suites 8m 29s ⏱️ Results for commit f1e0f24. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results 24 files 24 suites 14m 21s ⏱️ Results for commit f1e0f24. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Misc) Results 59 files 59 suites 16m 52s ⏱️ Results for commit f1e0f24. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results19 tests 19 ✅ 22m 40s ⏱️ Results for commit f1e0f24. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results 82 files 82 suites 24m 32s ⏱️ Results for commit f1e0f24. ♻️ This comment has been updated with latest results. |
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
b923b85
to
f6e1534
Compare
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the unit tests, using subject.preHandle(preHandleContext)).doesNotThrowAnyException();
doesn't seem sufficient, especially when preHandleContext
is a mock
...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java
Outdated
Show resolved
Hide resolved
...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java
Outdated
Show resolved
Hide resolved
...st/java/com/hedera/node/app/service/token/impl/test/handlers/TokenUpdateNftsHandlerTest.java
Show resolved
Hide resolved
...st/java/com/hedera/node/app/service/token/impl/test/handlers/TokenUpdateNftsHandlerTest.java
Show resolved
Hide resolved
...st/java/com/hedera/node/app/service/token/impl/test/handlers/TokenUpdateNftsHandlerTest.java
Show resolved
Hide resolved
...de/test-clients/src/main/java/com/hedera/services/bdd/suites/token/TokenUpdateNftsSuite.java
Show resolved
Hide resolved
...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java
Outdated
Show resolved
Hide resolved
...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java
Outdated
Show resolved
Hide resolved
...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java
Outdated
Show resolved
Hide resolved
...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java
Show resolved
Hide resolved
...pl/src/main/java/com/hedera/node/app/service/token/impl/handlers/TokenUpdateNftsHandler.java
Outdated
Show resolved
Hide resolved
...de/test-clients/src/main/java/com/hedera/services/bdd/suites/token/TokenUpdateNftsSuite.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @derektriley 🙌 ! Overall Looks good. Have some comments.
… tests Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks @derektriley 🙌
...de/test-clients/src/main/java/com/hedera/services/bdd/suites/token/TokenUpdateNftsSuite.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Derek Riley <derek.riley@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @derektriley
* develop: (22 commits) ci: stop release 0.51 regression (#14290) refactor: 14230 Removed `uptimeData` feature. (#14231) chore: HAPI cloneHederaProtobufs back to main (#14298) feat: HIP-850: HTS mutable metadata in treasury (#14204) chore: Remove unused script (#14266) feat: use platform event post consensus (#14256) chore: Removed allowances modification on `TokenReject` (#14282) chore: Added newlines to property-files (#14275) test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267) fix: node remove test (#14237) feat: Add new pbj event hasher (#14226) chore: updated perf nightly workflow (#14263) docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558) feat: hapi tests for DAB createNode (#14228) feat(reconnect): log ReconnectMapStats (#14250) chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232) chore: Made StakingValidator static (#14159) feat: require admin key for maxAutoAssociations during contractUpdate (#14161) build: filter publishing by deactivating tasks (develop) (#14187) docs: Extend design doc for HIP-719 (#14212) ... # Conflicts: # hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/api/TokenServiceApiProvider.java # hedera-node/hedera-token-service-impl/src/test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoDeleteHandlerTest.java
Description:
This PR implements the functionality required for HIP-850
Enhancing Supply Key Functionality for NFT Updates in Treasury Account. Specifically enabling the Supply Key to update an NFT metadata field while the NFT is held in the treasury account
See hashgraph/hedera-protobufs#394
for protobuf changes (new
ResponseCodeEnum
value).Fixes #14109
Notes for reviewer:
Checklist