-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hapi tests for DAB createNode #14228
Conversation
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
…o 14174-Hapi-tests-createnode # Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/addressbook/NodeCreateSuite.java
…o 14174-Hapi-tests-createnode Updates to tests Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
More updates to tests Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Update comments Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Node: Unit Test Results 1 531 files 1 531 suites 3h 11m 29s ⏱️ Results for commit dd798fd. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Node Death Reconnect) Results3 tests 3 ✅ 5m 45s ⏱️ Results for commit dd798fd. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Token) Results 22 files 22 suites 7m 2s ⏱️ Results for commit dd798fd. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Restart) Results7 files 7 suites 6m 20s ⏱️ Results for commit dd798fd. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Crypto) Results 24 files 24 suites 13m 51s ⏱️ Results for commit dd798fd. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Misc) Results 59 files 59 suites 15m 10s ⏱️ Results for commit dd798fd. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Time Consuming) Results19 tests 19 ✅ 22m 34s ⏱️ Results for commit dd798fd. ♻️ This comment has been updated with latest results. |
Node: HAPI Test (Smart Contract) Results 80 files 80 suites 23m 11s ⏱️ Results for commit dd798fd. ♻️ This comment has been updated with latest results. |
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
...e/test-clients/src/main/java/com/hedera/services/bdd/suites/addressbook/NodeCreateSuite.java
Outdated
Show resolved
Hide resolved
...e/test-clients/src/main/java/com/hedera/services/bdd/suites/addressbook/NodeCreateSuite.java
Outdated
Show resolved
Hide resolved
...e/test-clients/src/main/java/com/hedera/services/bdd/suites/addressbook/NodeCreateSuite.java
Outdated
Show resolved
Hide resolved
...e/test-clients/src/main/java/com/hedera/services/bdd/suites/addressbook/NodeCreateSuite.java
Outdated
Show resolved
Hide resolved
…reatenode # Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/node/HapiNodeCreate.java
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
…reatenode # Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip869/NodeCreateTest.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip869/NodeUpdateTest.java
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14228 +/- ##
=============================================
- Coverage 67.58% 57.61% -9.98%
+ Complexity 36486 21878 -14608
=============================================
Files 3732 2853 -879
Lines 149767 109857 -39910
Branches 15571 11257 -4314
=============================================
- Hits 101223 63293 -37930
+ Misses 44179 42988 -1191
+ Partials 4365 3576 -789 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
…o 14174-Hapi-tests-createnode
...ra-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip869/NodeCreateTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one comment
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
.../test-clients/src/main/java/com/hedera/services/bdd/junit/hedera/utils/AddressBookUtils.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Small comments. Thanks @povolev15 @kimbor
* develop: (528 commits) chore: Remove unused script (#14266) feat: use platform event post consensus (#14256) chore: Removed allowances modification on `TokenReject` (#14282) chore: Added newlines to property-files (#14275) test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267) fix: node remove test (#14237) feat: Add new pbj event hasher (#14226) chore: updated perf nightly workflow (#14263) docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558) feat: hapi tests for DAB createNode (#14228) feat(reconnect): log ReconnectMapStats (#14250) chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232) chore: Made StakingValidator static (#14159) feat: require admin key for maxAutoAssociations during contractUpdate (#14161) build: filter publishing by deactivating tasks (develop) (#14187) docs: Extend design doc for HIP-719 (#14212) feat: add isAssociated system contract (#14169) chore: File Service compiler warning fixes (#14216) fix: Fix casting exception for event-stream recover (#14055) feat: hashgraph GUI fixes (#14060) ... # Conflicts: # hapi/build.gradle.kts # hapi/src/main/java/com/hedera/hapi/util/HapiUtils.java # hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ApiPermissionConfig.java # hedera-node/hedera-mono-service/src/main/java/com/hedera/node/app/service/mono/pbj/PbjConverter.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/TxnFactory.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenCreate.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenUpdate.java
* develop: (22 commits) ci: stop release 0.51 regression (#14290) refactor: 14230 Removed `uptimeData` feature. (#14231) chore: HAPI cloneHederaProtobufs back to main (#14298) feat: HIP-850: HTS mutable metadata in treasury (#14204) chore: Remove unused script (#14266) feat: use platform event post consensus (#14256) chore: Removed allowances modification on `TokenReject` (#14282) chore: Added newlines to property-files (#14275) test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267) fix: node remove test (#14237) feat: Add new pbj event hasher (#14226) chore: updated perf nightly workflow (#14263) docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558) feat: hapi tests for DAB createNode (#14228) feat(reconnect): log ReconnectMapStats (#14250) chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232) chore: Made StakingValidator static (#14159) feat: require admin key for maxAutoAssociations during contractUpdate (#14161) build: filter publishing by deactivating tasks (develop) (#14187) docs: Extend design doc for HIP-719 (#14212) ... # Conflicts: # hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/api/TokenServiceApiProvider.java # hedera-node/hedera-token-service-impl/src/test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoDeleteHandlerTest.java
Create hapi tests for Dynamic Address Book NodeCreate functionality.
Related issue(s):
Fixes #14174