Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hapi tests for DAB createNode #14228

Merged
merged 26 commits into from
Jul 16, 2024
Merged

Conversation

kimbor
Copy link
Member

@kimbor kimbor commented Jul 12, 2024

Create hapi tests for Dynamic Address Book NodeCreate functionality.

Related issue(s):

Fixes #14174

povolev15 and others added 10 commits July 9, 2024 14:28
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
…o 14174-Hapi-tests-createnode

# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/addressbook/NodeCreateSuite.java
…o 14174-Hapi-tests-createnode

Updates to tests

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
More updates to tests
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Update comments
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor added the Dynamic Address Book All issues related to dynamic address book label Jul 12, 2024
@kimbor kimbor added this to the v0.53 milestone Jul 12, 2024
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Copy link

github-actions bot commented Jul 12, 2024

Node: Unit Test Results

  1 531 files    1 531 suites   3h 11m 29s ⏱️
115 758 tests 115 699 ✅ 59 💤 0 ❌
123 962 runs  123 903 ✅ 59 💤 0 ❌

Results for commit dd798fd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 12, 2024

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 45s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit dd798fd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 12, 2024

Node: HAPI Test (Token) Results

 22 files   22 suites   7m 2s ⏱️
273 tests 273 ✅ 0 💤 0 ❌
351 runs  351 ✅ 0 💤 0 ❌

Results for commit dd798fd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 12, 2024

Node: HAPI Test (Restart) Results

7 files  7 suites   6m 20s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit dd798fd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 12, 2024

Node: HAPI Test (Crypto) Results

 24 files   24 suites   13m 51s ⏱️
347 tests 347 ✅ 0 💤 0 ❌
372 runs  372 ✅ 0 💤 0 ❌

Results for commit dd798fd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 12, 2024

Node: HAPI Test (Misc) Results

 59 files   59 suites   15m 10s ⏱️
316 tests 316 ✅ 0 💤 0 ❌
398 runs  398 ✅ 0 💤 0 ❌

Results for commit dd798fd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 12, 2024

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  22m 34s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit dd798fd.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 12, 2024

Node: HAPI Test (Smart Contract) Results

 80 files   80 suites   23m 11s ⏱️
648 tests 648 ✅ 0 💤 0 ❌
754 runs  754 ✅ 0 💤 0 ❌

Results for commit dd798fd.

♻️ This comment has been updated with latest results.

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor marked this pull request as ready for review July 12, 2024 14:54
@kimbor kimbor requested review from a team as code owners July 12, 2024 14:54
@kimbor kimbor requested a review from jasperpotts July 12, 2024 14:54
…reatenode

# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/node/HapiNodeCreate.java
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
povolev15 and others added 4 commits July 12, 2024 16:36
…reatenode

# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip869/NodeCreateTest.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/hip869/NodeUpdateTest.java
Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.61%. Comparing base (9973fae) to head (dd798fd).
Report is 142 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #14228      +/-   ##
=============================================
- Coverage      67.58%   57.61%   -9.98%     
+ Complexity     36486    21878   -14608     
=============================================
  Files           3732     2853     -879     
  Lines         149767   109857   -39910     
  Branches       15571    11257    -4314     
=============================================
- Hits          101223    63293   -37930     
+ Misses         44179    42988    -1191     
+ Partials        4365     3576     -789     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one comment

Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small comments. Thanks @povolev15 @kimbor

@povolev15 povolev15 merged commit 075d35c into develop Jul 16, 2024
44 of 45 checks passed
@povolev15 povolev15 deleted the 14174-Hapi-tests-createnode branch July 16, 2024 18:53
netopyr added a commit that referenced this pull request Jul 18, 2024
* develop: (528 commits)
  chore: Remove unused script (#14266)
  feat: use platform event post consensus (#14256)
  chore: Removed allowances modification on `TokenReject` (#14282)
  chore: Added newlines to property-files (#14275)
  test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267)
  fix: node remove test (#14237)
  feat: Add new pbj event hasher (#14226)
  chore: updated perf nightly workflow (#14263)
  docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558)
  feat: hapi tests for DAB createNode (#14228)
  feat(reconnect): log ReconnectMapStats (#14250)
  chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232)
  chore: Made StakingValidator static (#14159)
  feat: require admin key for maxAutoAssociations during contractUpdate (#14161)
  build: filter publishing by deactivating tasks (develop) (#14187)
  docs: Extend design doc for HIP-719 (#14212)
  feat: add isAssociated system contract (#14169)
  chore: File Service compiler warning fixes (#14216)
  fix: Fix casting exception for event-stream recover (#14055)
  feat: hashgraph GUI fixes (#14060)
  ...

# Conflicts:
#	hapi/build.gradle.kts
#	hapi/src/main/java/com/hedera/hapi/util/HapiUtils.java
#	hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ApiPermissionConfig.java
#	hedera-node/hedera-mono-service/src/main/java/com/hedera/node/app/service/mono/pbj/PbjConverter.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/TxnFactory.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenCreate.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenUpdate.java
netopyr added a commit that referenced this pull request Jul 19, 2024
* develop: (22 commits)
  ci: stop release 0.51 regression (#14290)
  refactor: 14230 Removed `uptimeData` feature. (#14231)
  chore: HAPI cloneHederaProtobufs back to main (#14298)
  feat: HIP-850: HTS mutable metadata in treasury (#14204)
  chore: Remove unused script (#14266)
  feat: use platform event post consensus (#14256)
  chore: Removed allowances modification on `TokenReject` (#14282)
  chore: Added newlines to property-files (#14275)
  test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267)
  fix: node remove test (#14237)
  feat: Add new pbj event hasher (#14226)
  chore: updated perf nightly workflow (#14263)
  docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558)
  feat: hapi tests for DAB createNode (#14228)
  feat(reconnect): log ReconnectMapStats (#14250)
  chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232)
  chore: Made StakingValidator static (#14159)
  feat: require admin key for maxAutoAssociations during contractUpdate (#14161)
  build: filter publishing by deactivating tasks (develop) (#14187)
  docs: Extend design doc for HIP-719 (#14212)
  ...

# Conflicts:
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/api/TokenServiceApiProvider.java
#	hedera-node/hedera-token-service-impl/src/test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoDeleteHandlerTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dynamic Address Book All issues related to dynamic address book
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add hapi test for nodeCreateSuite
5 participants