Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

name for auto generated key doesn't always match #36

Closed
scott2449 opened this issue Oct 13, 2018 · 4 comments · Fixed by #39
Closed

name for auto generated key doesn't always match #36

scott2449 opened this issue Oct 13, 2018 · 4 comments · Fixed by #39

Comments

@scott2449
Copy link

scott2449 commented Oct 13, 2018 •
edited
Loading

Dynamic:
https://github.com/hashicorp/consul-helm/blob/master/templates/connect-inject-mutatingwebhook.yaml#L6
Static:
https://github.com/hashicorp/consul-helm/blob/master/templates/connect-inject-deployment.yaml#L53

I'd PR but I'm not sure how you'd want to handle that.. if it's variable or static in both locations just let me know and I can submit one.
@scott2449
Copy link
Author

this and #13 are blockers for this chart launching on vanilla docker for windows/mac

@scott2449
Copy link
Author

In case this was not clear enough it causes the hook container to fail because it cannot find the certificate.

@anubhavmishra anubhavmishra mentioned this issue Oct 15, 2018
Merged
@mitchellh
Copy link
Contributor

Ouch sorry! We'll get this fixed ASAP and cut a patch release this week. Sorry about that.

anubhavmishra added a commit to anubhavmishra/consul-helm that referenced this issue Oct 16, 2018
@anubhavmishra
Fix connect inject configuration name
69c2751 
Doing this PR separately to fix hashicorp#36 since it is independent of my [PR](hashicorp#37) for RBAC for the injector.
@anubhavmishra anubhavmishra mentioned this issue Oct 16, 2018
Merged
@anubhavmishra
Copy link
Member

@scott2449 I just fixed the configuration name that the injector uses. Hopefully, that helps!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix connect inject configuration name anubhavmishra/consul-helm
3 participants
@mitchellh @scott2449 @anubhavmishra