Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NET-9098] Narrow scope of peering config on terminating gw filter chain to TCP services #21054

Merged
merged 1 commit into from
May 6, 2024

Conversation

nathancoleman
Copy link
Member

Description

This narrows the scope of changes made previously in #19881 which have unintentionally impacted http config on terminating gateway filter chains

Testing & Reproduction steps

Run the consul-k8s peering acceptance test with transparent proxy and CNI flavors using a build of this consul-enterprise branch. The test that is currently broken should pass with this build.

Example:

$ cd consul-k8s
$ make kind-small
$ cd acceptance
$ go test ./tests/peering -v -p 1 -timeout 20m -count=1 -run ^TestPeering_Connect$ \
        -enable-multi-cluster -kube-contexts="kind-dc1,kind-dc2" -use-kind \
        -enable-transparent-proxy -consul-image '<image here>'

There are existing xDS golden tests that cover TCP services. Those updates can be seen in #19881.

Additionally, we have followup work to add tcp-specific peering acceptance test coverage where there isn't any today. This is followup work so that we can go ahead and unblock the failing tests and upcoming release over in the consul-k8s repo.

Links

Example acceptance test failure in consul-k8s

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@nathancoleman nathancoleman added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.18 labels May 6, 2024
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants