Skip to content

Conversation

zamoore
Copy link
Contributor

@zamoore zamoore commented Sep 19, 2025

📌 Summary

If merged, this PR removed the deprecated @text argument from the HdsDropdownListItemInteractive component.

🔗 External links

Jira ticket: HDS-5506


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@zamoore zamoore requested a review from a team as a code owner September 19, 2025 19:33
Copy link

vercel bot commented Sep 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Oct 1, 2025 1:23am
hds-website Ready Ready Preview Oct 1, 2025 1:23am

@zamoore zamoore force-pushed the zamoore/hds-5506/HdsDropdownListItemInteractive-remove_text branch from ec759cb to 441813d Compare September 19, 2025 19:33
@zamoore zamoore requested a review from a team as a code owner September 22, 2025 14:53
@zamoore zamoore force-pushed the main-5.0.0 branch 4 times, most recently from 468a8bc to 79d8cc2 Compare September 23, 2025 12:59
@zamoore zamoore force-pushed the zamoore/hds-5506/HdsDropdownListItemInteractive-remove_text branch from 342b659 to 98908e6 Compare September 23, 2025 13:01
@zamoore zamoore changed the title Zamoore/hds 5506/hds dropdown list item interactive remove text HdsDropdownListItemInteractive - Remove deprecated @text argument Sep 23, 2025
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the integration tests need to be updated

(the documentation will be updated in a separate branch/PR? I saw another PR where it was done in the same branch)

@zamoore
Copy link
Contributor Author

zamoore commented Sep 24, 2025

the integration tests need to be updated

(the documentation will be updated in a separate branch/PR? I saw another PR where it was done in the same branch)

all set now

@zamoore zamoore requested a review from didoo September 24, 2025 19:59
@zamoore zamoore merged commit 708ecef into main-5.0.0 Oct 1, 2025
22 of 23 checks passed
@zamoore zamoore deleted the zamoore/hds-5506/HdsDropdownListItemInteractive-remove_text branch October 1, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-website Content updates to the documentation website packages/components showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants