Spike multiple CSS output in rollup #3235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
didoo
force-pushed
the
project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding
branch
from
5f73b3f to
19234bc
Compare
5 tasks
didoo
force-pushed
the
project-solar/phase-1/HDS-5242_showcase/carbonization-pages-scaffolding
branch
5 times, most recently
from
9376a33 to
8bc9cc9
Compare
|
Incorporated in #3259 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
rollup-plugin-scssis unfortunately limited to outputting a single CSS file.This PR is a proof of concept for a rollup plugin that compiles SCSS (with different include paths) to CSS as part of the build pipeline and fails if the sass compilation encounters any errors. This will serve as a basis for themed tokens using either css selectors of
prefers-color-scheme.🔗 External links
Jira ticket: HDS-5505
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.