-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump code-block for shell-sesh fix #1268
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Some suggested prefixes and emojis that may help to write clear, actionable code review comments:
Expand for comment prefix descriptions
|
π¦ Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action π€ This PR introduced no changes to the javascript bundle π |
package.json
Outdated
@@ -105,7 +105,7 @@ | |||
"@hashicorp/react-button": "^6.2.1", | |||
"@hashicorp/react-call-to-action": "^4.1.1", | |||
"@hashicorp/react-checkbox-input": "^5.0.2", | |||
"@hashicorp/react-code-block": "^6.2.0", | |||
"@hashicorp/react-code-block": "^6.2.1-canary-20221019235743", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π§ Will bump to stable once hashicorp/react-components#768 lands π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
β released & bumped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good detective work π΅οΈ
π Relevant links
ποΈ What
Bumps
@hashicorp/react-code-block
to pull in a fix forshell-session
CodeTabs
from hashicorp/react-components#768.π€· Why
Fixes a bug where
shell-session
snippets withinCodeTabs
would copy correctly via theCopy
button, but would still include the$
character when selected and copied by clicking and dragging.π§ͺ Testing
shell-session
snippets in MDXCodeTabs
, such as /consul/tutorials/network-infrastructure-automation/consul-terraform-sync-introCopy
button should copy without the leading$
or leading space that follows it$
.shell-session
snippets with multiple commands.π Anything else?
See hashicorp/react-components#768 for details, including screenshots etc.