Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump code-block for shell-sesh fix #1268

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Conversation

zchsh
Copy link
Contributor

@zchsh zchsh commented Oct 20, 2022

πŸ”— Relevant links

πŸ—’οΈ What

Bumps @hashicorp/react-code-block to pull in a fix for shell-session CodeTabs from hashicorp/react-components#768.

🀷 Why

Fixes a bug where shell-session snippets within CodeTabs would copy correctly via the Copy button, but would still include the $ character when selected and copied by clicking and dragging.

πŸ§ͺ Testing

  • Visit a page with shell-session snippets in MDX CodeTabs, such as /consul/tutorials/network-infrastructure-automation/consul-terraform-sync-intro
    • The Copy button should copy without the leading $ or leading space that follows it
    • Selecting and copying all the text (eg by triple-clicking) should copy without the leading $.
      • Note the leading space will be copied, this is a difficult thing to optimize, and we haven't yet had the bandwidth to scope out a more holistic and robust approach to authoring and rendering shell-session snippets with multiple commands.
      • The leading space shouldn't affect the functionality of the command.

πŸ’­ Anything else?

See hashicorp/react-components#768 for details, including screenshots etc.

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
dev-portal βœ… Ready (Inspect) Visit Preview Oct 20, 2022 at 2:32PM (UTC)

@github-actions
Copy link

Some suggested prefixes and emojis that may help to write clear, actionable code review comments:

Praise πŸ™Œ Question πŸ™‹ Thought πŸ’­ Blocker 🚧 Future πŸ“Œ Optional 🎨 Nitpick ⛏️
Expand for comment prefix descriptions
Prefix+Emoji Description
Praise πŸ™Œ Use to highlight something positive. It's nice to try to leave one per review, but don't leave false praise just to leave one of these comments.
Question πŸ™‹ Use to gain clarity from the code author. The conversation could evolve into any one of these other categories. Only the reviewer should resolve these comment threads.
Thought πŸ’­ Use to share context, leave a breadcrumb, or share an idea that came up while reviewing.
Blocker 🚧 Use to request changes that block merging the current PR. Only the reviewer should resolve these comment threads.
Future πŸ“Œ Use to request changes that the code author can choose to address in the current PR or a follow-up one.
Optional 🎨 Use to suggest optional changes that you feel strongly about but ultimately defer to the code author to make a decision on. These can be comments that turn into valuable conversation starters for adopting new code styles, guidelines, or team practices.
Nitpick ⛏️ Use to suggest changes based on loose opinions or personal preferences. The difference between this and Optional 🎨  is how strong the code reviewer's opinion is.

@github-actions
Copy link

github-actions bot commented Oct 20, 2022

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

This PR introduced no changes to the javascript bundle πŸ™Œ

package.json Outdated
@@ -105,7 +105,7 @@
"@hashicorp/react-button": "^6.2.1",
"@hashicorp/react-call-to-action": "^4.1.1",
"@hashicorp/react-checkbox-input": "^5.0.2",
"@hashicorp/react-code-block": "^6.2.0",
"@hashicorp/react-code-block": "^6.2.1-canary-20221019235743",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧 Will bump to stable once hashicorp/react-components#768 lands πŸ‘

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… released & bumped

@zchsh zchsh requested a review from a team October 20, 2022 00:42
Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good detective work πŸ•΅οΈ

@zchsh zchsh merged commit 4b8a7c5 into main Oct 20, 2022
@zchsh zchsh deleted the zs.fix-code-tabs-lang-undefined branch October 20, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants