-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decoder: Add support for Object
as Constraint
#203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-expr-cons-object
branch
5 times, most recently
from
February 15, 2023 15:39
9662595
to
6c54ac0
Compare
This was referenced Feb 15, 2023
radeksimko
force-pushed
the
f-expr-cons-object
branch
8 times, most recently
from
February 16, 2023 10:29
654d10d
to
e453a62
Compare
radeksimko
force-pushed
the
f-expr-cons-object
branch
5 times, most recently
from
February 21, 2023 10:35
7640674
to
e28aef5
Compare
radeksimko
force-pushed
the
f-expr-cons-object
branch
5 times, most recently
from
February 21, 2023 19:47
f9dcbf1
to
1fad8ba
Compare
radeksimko
force-pushed
the
f-expr-cons-object
branch
3 times, most recently
from
March 10, 2023 18:53
fa36385
to
861df7a
Compare
This was referenced Mar 13, 2023
radeksimko
force-pushed
the
f-expr-cons-object
branch
7 times, most recently
from
March 14, 2023 18:26
26bed52
to
ece2ea1
Compare
radeksimko
force-pushed
the
f-expr-cons-object
branch
from
March 14, 2023 19:19
7bded4f
to
6865a7e
Compare
radeksimko
force-pushed
the
f-expr-cons-object
branch
from
March 15, 2023 08:12
6865a7e
to
f9965ed
Compare
dbanck
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great and thanks for testing all the edge cases 👍
I only stumbled across two small things.
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-ls#496
Depends on #230
Existing tests were updated as part of fd9193b (not part of this PR) and yield either comparable or better results, except for reference collection, which:
UX
(with pre-filling required attributes)
(without pre-filling required attributes)