Skip to content

fix: center inline-video description #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

LeahMarieBush
Copy link
Contributor

@LeahMarieBush LeahMarieBush commented Sep 4, 2024

🎟️ Asana Task
πŸ” Preview Link


Description

This PR centers the description below the video for inline-videos. This came in as a request from the Web Presence Request form. More info on why is in the Asana task.

To fix this, I added text-align: center to the video description.

Testing

  1. Go to preview link
  2. At the top, note that the descriptions below the videos are centered

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
react-components βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Sep 4, 2024 6:56pm

Copy link

changeset-bot bot commented Sep 4, 2024

πŸ¦‹ Changeset detected

Latest commit: 659481c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-inline-video Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LeahMarieBush LeahMarieBush marked this pull request as ready for review September 4, 2024 19:02
@LeahMarieBush LeahMarieBush requested review from a team and nandereck and removed request for a team September 4, 2024 19:02
@nandereck
Copy link
Contributor

@LeahMarieBush - what's the reason for the package-lock.json change?

Copy link
Contributor

@nandereck nandereck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the change to package-lock.json. Otherwise, LGTM!

@LeahMarieBush
Copy link
Contributor Author

LeahMarieBush commented Sep 4, 2024

@LeahMarieBush - what's the reason for the package-lock.json change?

@nandereck I ran npm i after creating the branch and it updated the package-lock.json file. I looked at the updated versions and they are all accurate with the current versions of each updated package. I would guess that the packages got updated but there was no corresponding npm i command run, probably because the bot updates the packages after each PR is merged

@nandereck
Copy link
Contributor

@LeahMarieBush - what's the reason for the package-lock.json change?

@nandereck I ran npm i after creating the branch and it updated the package-lock.json file. I looked at the updated versions and they are all accurate with the current versions of each updated package. I would guess that the packages got updated but there was no corresponding npm i command run, probably because the bot updates the packages after each PR is merged

Cool SG!

@LeahMarieBush LeahMarieBush merged commit 96ae822 into main Sep 4, 2024
7 checks passed
@LeahMarieBush LeahMarieBush deleted the leah/fix/center-video-description branch September 4, 2024 20:20
@hashibot-web hashibot-web mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants