Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-subnav): scroll-margin-top style #417

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

thiskevinwang
Copy link
Contributor

@thiskevinwang thiskevinwang commented Nov 3, 2021

🎟️ Asana Task
πŸ” Preview Link

Relates to


Description

This unnests scroll-margin-top styling from the .isSticky class.

Preview usage: https://waypoint-p3qzymh84-hashicorp.vercel.app/commands/logs#usage

PR Checklist πŸš€

Items in this checklist may not may not apply to your PR, but please consider each item carefully.

  • Add Asana and Preview links above.
  • Conduct thorough self-review.
  • Add or update tests as appropriate.
  • Conduct reasonable cross browser testing for both compatibility and responsive behavior (We have a Sauce Labs account for this, if you don't have access, just ask!).
  • Conduct reasonable accessibility review (use the WAS as a guide or an axe browser plugin until we establish more formal checks).
  • Identify (in the description above) and document (add Asana tasks on this board) any technical debt that you're aware of, but are not addressing as part of this PR.

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2021

πŸ¦‹ Changeset detected

Latest commit: f4636bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/react-subnav Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/hashicorp/react-components/7D4ibpTVA5PTJd9JTHmgAVha3BnQ
βœ… Preview: https://react-components-git-kevin-subnav-scroll-hashicorp.vercel.app

@thiskevinwang thiskevinwang requested a review from a team November 3, 2021 17:11
@thiskevinwang thiskevinwang added the release:canary Triggers a canary release for commits to this pull request label Nov 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

πŸ“¦ Canary Packages Published

Latest commit: f4636bc

Published 1 packages

@hashicorp/react-subnav@9.1.4-canary-2021103173547

npm install @hashicorp/react-subnav@canary

Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’―

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Triggers a canary release for commits to this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants