Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename PUBLISH_GITHUB_TOKEN to CHANGESETS_PAT #955

Merged
merged 3 commits into from
May 4, 2023
Merged

rename PUBLISH_GITHUB_TOKEN to CHANGESETS_PAT #955

merged 3 commits into from
May 4, 2023

Conversation

thiskevinwang
Copy link
Contributor

@thiskevinwang thiskevinwang commented May 4, 2023 •
edited
Loading

Update workflow call params

see hashicorp/web-platform-packages#218

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 248da2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 6:40pm

@thiskevinwang thiskevinwang changed the title rename PUBLISH_GITHUB_TOKEN to CHANGESETS_PAT - https://github.com/hashicorp/web-platform-packages/pull/218 rename PUBLISH_GITHUB_TOKEN to CHANGESETS_PAT May 4, 2023
@thiskevinwang thiskevinwang requested a review from a team May 4, 2023 18:36
thiskevinwang
thiskevinwang commented May 4, 2023
View reviewed changes
.github/workflows/release.yml Outdated
@@ -7,7 +7,7 @@ on:

jobs:
release:
uses: hashicorp/web-platform-packages/.github/workflows/release.yml@8f20ba3ccb4ffe9a9bc0b14060af00929e6655f1
uses: hashicorp/web-platform-packages/.github/workflows/release.yml@_______FIXME______
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be updated with the new SHA when hashicorp/web-platform-packages#218 is merged

@thiskevinwang thiskevinwang merged commit 0db5ed2 into main May 4, 2023
@thiskevinwang thiskevinwang deleted the kw.secret-naming branch May 4, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayres nayres nayres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiskevinwang @nayres