Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a semantic error #626

Merged
merged 2 commits into from
Jul 20, 2021
Merged

fix a semantic error #626

merged 2 commits into from
Jul 20, 2021

Conversation

moooofly
Copy link
Contributor

No description provided.

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 24, 2021

CLA assistant check
All committers have signed the CLA.

@moooofly
Copy link
Contributor Author

It seems not a real error.

=== RUN   TestRTTCommand_Run_BadArgs
    TestRTTCommand_Run_BadArgs: log.go:181: 2021/02/24 01:49:03 [INFO] agent: Serf agent starting
    TestRTTCommand_Run_BadArgs: log.go:181: 2021/02/24 01:49:03 [DEBUG] memberlist: Got bind error: Failed to start TCP listener on "127.0.0.77" port 7946: listen tcp 127.0.0.77:7946: bind: address already in use
    TestRTTCommand_Run_BadArgs: util_test.go:42: err: Error creating Serf: Failed to create memberlist: Could not set up network transport: failed to obtain an address: Failed to start TCP listener on "127.0.0.77" port 7946: listen tcp 127.0.0.77:7946: bind: address already in use
--- FAIL: TestRTTCommand_Run_BadArgs (0.10s)

Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! I'm not sure why that test keeps failing, but it does pass locally for me on this branch and does not appear to be related to this change.

I made one other small change to the language in this error message.

@dnephin dnephin merged commit aa5efb7 into hashicorp:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants