Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Update cli configuration doc #1111

Merged
merged 2 commits into from
Sep 30, 2021
Merged

chore(docs): Update cli configuration doc #1111

merged 2 commits into from
Sep 30, 2021

Conversation

schersh
Copy link
Contributor

@schersh schersh commented Sep 30, 2021

Closes #998

This PR adds a link to the cdktf.json documentation.

@schersh schersh added the documentation Improvements or additions to documentation label Sep 30, 2021
laurapacilio
laurapacilio approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :-)

My only question is - I originally felt like the telemetry stuff belonged here because it's really applying to the CLI but now we have our own telemetry page. Should we shorten that here and link to the larger telemetry page that Daniel wrote?

@schersh
Copy link
Contributor Author

schersh commented Sep 30, 2021

Thank you! :-)

My only question is - I originally felt like the telemetry stuff belonged here because it's really applying to the CLI but now we have our own telemetry page. Should we shorten that here and link to the larger telemetry page that Daniel wrote?

I'll add a link to the primary telemetry page, thanks!

laurapacilio
laurapacilio approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Ship it! 🚀

@schersh schersh merged commit d1ac7d9 into terraform-io-docs Sep 30, 2021
@schersh schersh deleted the sm/update-config-doc branch September 30, 2021 21:35
@DanielMSchmidt DanielMSchmidt mentioned this pull request Oct 19, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laurapacilio laurapacilio laurapacilio approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schersh @laurapacilio