fix: do not always overwrite global.performance #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
robertkowalski
force-pushed
the
fix-performance-global
branch
from
a2a8a84
to
43a7212
Compare
|
I forked the repository to run all the unit tests |
|
robertkowalski
force-pushed
the
fix-performance-global
branch
from
e093d2b
to
43a7212
Compare
robertkowalski
requested review from
ansgarm and
DanielMSchmidt
and removed request for
a team
DanielMSchmidt
requested review from
mutahhir
and removed request for
DanielMSchmidt
robertkowalski
force-pushed
the
fix-performance-global
branch
from
43a7212
to
bf4d57b
Compare
|
@mutahhir updated and adjusted the commit message |
|
@mutahhir with the changes to crypto unit tests fail, i will revert the changes for crypto |
new node version already have a performance global, see https://nodejs.org/api/globals.html#performance it contains many methods, see https://nodejs.org/api/perf_hooks.html when always overwriting it, other modules like `undici` which use the performance object won't work any more. in general using the performance object becomes unusable as soon as the `@cdktf/hcl2json` package is required. discussion/bug: renovatebot/renovate#22615 this PR adjusts the checked in sourcefile to the latest upstream version: https://github.com/golang/go/blob/ee46f0b5084461978432aa20df003ac52500b0f0/misc/wasm/wasm_exec_node.js#L12-L17
robertkowalski
force-pushed
the
fix-performance-global
branch
from
bf4d57b
to
0120aef
Compare
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new node version already have a performance global, see https://nodejs.org/api/globals.html#performance
it contains many methods, see https://nodejs.org/api/perf_hooks.html
when always overwriting it, other modules like
undiciwhich use the performance object won't work any more. in genera using the performance object become unusable as soon as the@cdktf/hcl2jsonpackage is required.discussion/bug: renovatebot/renovate#22615
Related issue
Fixes #
Description
In plain English, describe your approach to addressing the issue linked above. For example, if you made a particular design decision, let us know why you chose this path instead of another solution.
Checklist