-
Notifications
You must be signed in to change notification settings - Fork 139
Update run api documentation for new query parameters #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so I don't block you, but a couple of minor edits. Largely, we want to try to stay away from italics when possible, so I incorporated those statements into the main text. Also! We want to use the most descriptive link text we can, so that users know what we mean. It's also helpful if, say, someone changes that subheading in the future but doesn't update the link. This will help users still find the information.
Thank you!
@laurapacilio Thanks for the great feedback! I went ahead and made the suggested changes. |
1da51a4
to
0e940ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions for you, but otherwise LGTM!
Co-authored-by: Laura Pacilio <83350965+laurapacilio@users.noreply.github.com>
Awesome, thank you again for the feedback! |
@mjyocca @laurapacilio it looks like the API changelog wasn't updated to reflect these changes. Should these be included? |
Yes :) @dylanegan thank you! @mjyocca would you mind please opening another PR to add this to the changelog file? https://ptfe-releases-gg5iuzrts-hashicorp.vercel.app/enterprise/api-docs/changelog |
@laurapacilio @dylanegan I'll go ahead and make the requested changes! |
Adding new documentation for terraform cloud api runs list around new query parameters
Task Link