importstate: a working example of ImportState as the first TestStep #461
Conversation
bbasata
force-pushed
the
import-as-first-test-step
branch
from
b8a65c8 to
70f740d
Compare
helper/resource/importstate/import_command_as_first_step_test.go
Outdated
Show resolved
Hide resolved
One detail that I remembered: the only reason As mentioned above, I've removed |
| if err := runPlanChecks(ctx, t, plan, step.ImportPlanChecks.PreApply); err != nil { | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
Not directly related to this PR, but I noticed that we don't immediately return after running this import/plan and we probably should? Or wrap the remaining of the logic in this function in the following else block.
There was a problem hiding this comment.
✅ Noted for a follow-up PR -- it will be easier to see the current picture after we merge this & the two PRs "stacked" atop it.
| // TODO compare plan to state from previous step | ||
|
|
||
| if err := runPlanChecks(ctx, t, plan, step.ImportPlanChecks.PreApply); err != nil { | ||
| return err |
There was a problem hiding this comment.
nit: Should we wrap the error messages produced by the plan checks for readability?
return fmt.Errorf("Import plan check(s) failed:\n%w", err)There was a problem hiding this comment.
✅ Noted for a follow-up PR -- it will be easier to see the current picture after we merge this & the two PRs "stacked" atop it.
This PR adds a test to resolve the question: what happens if the first
TestStepuses import mode?This test passes 🍏
Notably:
ImportStateVerifydoes not work, because there is no previous step state to verify against.