helper/resource: easy access to state in tfjson.State form
#473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures disappeared upon re-running. I will track issues for follow-up. This is ready for review. |
rainkwan
approved these changes
Apr 1, 2025
| var err error | ||
| err = runProviderCommand(ctx, t, func() error { | ||
| statePreDestroy, err = getState(ctx, t, wd) | ||
| _, statePreDestroy, err = getState(ctx, t, wd) |
There was a problem hiding this comment.
Subtle difference to keep track of, good thing the IDE helps
| } | ||
|
|
||
| // TODO: this statement is a placeholder -- it simply prevents stateJSON from being unused | ||
| logging.HelperResourceTrace(ctx, fmt.Sprintf("State before import: values %v", stateJSON.Values != nil)) |
There was a problem hiding this comment.
I should also use placeholders more
| // Explicitly ensure prior state exists before refresh. | ||
| err = runProviderCommand(ctx, t, func() error { | ||
| _, err = getState(ctx, t, wd) | ||
| _, _, err = getState(ctx, t, wd) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally,
resource.getStatetrades atfjson.Statestruct for aterraform.InstanceStatestruct. As discussed in #467 (comment), it would be super helpful to operate on thetfjsonstruct without translation.This pull request adds a return value to this unexported function. So this PR is a refactoring with no functional changes. I've added one logging statement to make the compiler and linter happy that there are no unused variables or parameters.