Skip to content

Conversation

jeremmfr
Copy link

@jeremmfr jeremmfr commented Jun 2, 2025

Related Issue

Fixes #516

Description

Store the ConfigDirectory and ConfigFile from the current step, so they can be used by subsequent ImportState steps if not explicitly set

@jeremmfr jeremmfr requested a review from a team as a code owner June 2, 2025 18:48
@austinvalle austinvalle mentioned this pull request Jun 4, 2025
1 task
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jeremmfr 👋🏻 , thanks for submitting the PR! #516 definitely looks like a regression from what you reported, which looks like we didn't have a test for.

This will need a changelog and a test covering the original issue, but I can add those before merging.

I've opened a mirror of your PR #520 to actually run our acceptance tests since they unfortunately can't run on forks 🙁 . Will look to review this soon and get a patch released 👍🏻

@austinvalle
Copy link
Member

Hey again @jeremmfr 👋🏻 , I reviewed your changes and did a little digging into the past context of how the regression occurred. We actually had a slightly different approach that I'm proposing to reinstate with #522, so I'm going to close this PR in favor of that one.

@austinvalle austinvalle closed this Jun 6, 2025
@jeremmfr jeremmfr deleted the issue-516 branch June 6, 2025 18:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.13.* : importstate doesn't use configuration from previous state with ConfigDirectory
2 participants