Enable new VPC Security Group Rule resources #29484

ewbankkit · 2023-02-17T21:16:30Z

Description

Enables the aws_vpc_security_group_egress_rule and aws_vpc_security_group_ingress_rule resources.

Relations

Closes #20104.
Closes #29404.
Relates #27680.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVPCSecurityGroupEgressRule_\|TestAccVPCSecurityGroupIngressRule_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSecurityGroupEgressRule_\|TestAccVPCSecurityGroupIngressRule_ -timeout 180m
=== RUN   TestAccVPCSecurityGroupEgressRule_basic
=== PAUSE TestAccVPCSecurityGroupEgressRule_basic
=== RUN   TestAccVPCSecurityGroupEgressRule_disappears
=== PAUSE TestAccVPCSecurityGroupEgressRule_disappears
=== RUN   TestAccVPCSecurityGroupIngressRule_basic
=== PAUSE TestAccVPCSecurityGroupIngressRule_basic
=== RUN   TestAccVPCSecurityGroupIngressRule_disappears
=== PAUSE TestAccVPCSecurityGroupIngressRule_disappears
=== RUN   TestAccVPCSecurityGroupIngressRule_tags
=== PAUSE TestAccVPCSecurityGroupIngressRule_tags
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== RUN   TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_ignoreTags
=== PAUSE TestAccVPCSecurityGroupIngressRule_ignoreTags
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv4
=== RUN   TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== PAUSE TestAccVPCSecurityGroupIngressRule_cidrIPv6
=== RUN   TestAccVPCSecurityGroupIngressRule_description
=== PAUSE TestAccVPCSecurityGroupIngressRule_description
=== RUN   TestAccVPCSecurityGroupIngressRule_prefixListID
=== PAUSE TestAccVPCSecurityGroupIngressRule_prefixListID
=== RUN   TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== PAUSE TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
=== RUN   TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== PAUSE TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== RUN   TestAccVPCSecurityGroupIngressRule_updateSourceType
=== PAUSE TestAccVPCSecurityGroupIngressRule_updateSourceType
=== CONT  TestAccVPCSecurityGroupEgressRule_basic
=== CONT  TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPCSecurityGroupEgressRule_basic (25.02s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToProviderOnly (37.29s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_duplicateTag (1.57s)
=== CONT  TestAccVPCSecurityGroupIngressRule_description
--- PASS: TestAccVPCSecurityGroupIngressRule_updateTagsKnownAtApply (46.72s)
=== CONT  TestAccVPCSecurityGroupIngressRule_updateSourceType
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_overlappingTag (46.42s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
    acctest.go:703: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC (0.00s)
=== CONT  TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID
--- PASS: TestAccVPCSecurityGroupIngressRule_updateSourceType (36.72s)
=== CONT  TestAccVPCSecurityGroupIngressRule_prefixListID
--- PASS: TestAccVPCSecurityGroupIngressRule_description (47.56s)
=== CONT  TestAccVPCSecurityGroupIngressRule_disappears
--- PASS: TestAccVPCSecurityGroupIngressRule_disappears (20.77s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_referencedSecurityGroupID (39.31s)
=== CONT  TestAccVPCSecurityGroupIngressRule_tags
--- PASS: TestAccVPCSecurityGroupIngressRule_prefixListID (47.01s)
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv4
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_providerOnly (47.00s)
=== CONT  TestAccVPCSecurityGroupIngressRule_cidrIPv6
--- PASS: TestAccVPCSecurityGroupIngressRule_tags (50.76s)
=== CONT  TestAccVPCSecurityGroupIngressRule_ignoreTags
--- PASS: TestAccVPCSecurityGroupIngressRule_cidrIPv4 (37.28s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccVPCSecurityGroupIngressRule_cidrIPv6 (37.69s)
=== CONT  TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags
--- PASS: TestAccVPCSecurityGroupIngressRule_ignoreTags (41.15s)
=== CONT  TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTagsProviderAndResource_nonOverlappingTag (45.94s)
=== CONT  TestAccVPCSecurityGroupIngressRule_basic
--- PASS: TestAccVPCSecurityGroupIngressRule_defaultAndIgnoreTags (41.26s)
=== CONT  TestAccVPCSecurityGroupEgressRule_disappears
--- PASS: TestAccVPCSecurityGroupIngressRule_basic (24.43s)
--- PASS: TestAccVPCSecurityGroupIngressRule_DefaultTags_updateToResourceOnly (36.82s)
--- PASS: TestAccVPCSecurityGroupEgressRule_disappears (20.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	259.296s
% make testacc TESTARGS='-run=TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC -timeout 180m
=== RUN   TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== PAUSE TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
=== CONT  TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC
--- PASS: TestAccVPCSecurityGroupIngressRule_ReferencedSecurityGroupID_peerVPC (28.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	34.109s
% make testacc TESTARGS='-run=TestAccVPCSecurityGroupRulesDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccVPCSecurityGroupRulesDataSource_ -timeout 180m
=== RUN   TestAccVPCSecurityGroupRulesDataSource_basic
=== PAUSE TestAccVPCSecurityGroupRulesDataSource_basic
=== RUN   TestAccVPCSecurityGroupRulesDataSource_tags
=== PAUSE TestAccVPCSecurityGroupRulesDataSource_tags
=== CONT  TestAccVPCSecurityGroupRulesDataSource_basic
=== CONT  TestAccVPCSecurityGroupRulesDataSource_tags
--- PASS: TestAccVPCSecurityGroupRulesDataSource_basic (23.17s)
--- PASS: TestAccVPCSecurityGroupRulesDataSource_tags (25.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	31.726s

…_ingress_rule' and 'aws_vpc_security_group_egress_rule'." This reverts commit bcf74a1.

…ess_rule' and 'aws_vpc_security_group_egress_rule'." This reverts commit cde1055.

github-actions · 2023-02-17T21:17:42Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

…h a single newline character'.

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCSecurityGroupRulesDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccVPCSecurityGroupRulesDataSource_ -timeout 180m === RUN TestAccVPCSecurityGroupRulesDataSource_basic === PAUSE TestAccVPCSecurityGroupRulesDataSource_basic === RUN TestAccVPCSecurityGroupRulesDataSource_tags === PAUSE TestAccVPCSecurityGroupRulesDataSource_tags === CONT TestAccVPCSecurityGroupRulesDataSource_basic === CONT TestAccVPCSecurityGroupRulesDataSource_tags --- PASS: TestAccVPCSecurityGroupRulesDataSource_basic (23.17s) --- PASS: TestAccVPCSecurityGroupRulesDataSource_tags (25.95s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 31.726s

Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCSecurityGroupRuleDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccVPCSecurityGroupRuleDataSource_ -timeout 180m === RUN TestAccVPCSecurityGroupRuleDataSource_basic === PAUSE TestAccVPCSecurityGroupRuleDataSource_basic === RUN TestAccVPCSecurityGroupRuleDataSource_filter === PAUSE TestAccVPCSecurityGroupRuleDataSource_filter === CONT TestAccVPCSecurityGroupRuleDataSource_basic === CONT TestAccVPCSecurityGroupRuleDataSource_filter --- PASS: TestAccVPCSecurityGroupRuleDataSource_basic (23.71s) --- PASS: TestAccVPCSecurityGroupRuleDataSource_filter (23.93s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 29.347s

…h a single newline character'.

github-actions · 2023-02-24T19:57:26Z

This functionality has been released in v4.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2023-03-27T02:12:39Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ewbankkit added 3 commits February 17, 2023 14:56

Revert "Remove any external visible traces of 'aws_vpc_security_group…

938d04b

…_ingress_rule' and 'aws_vpc_security_group_egress_rule'." This reverts commit bcf74a1.

Revert "Comment out self-registration of 'aws_vpc_security_group_ingr…

3e9448a

…ess_rule' and 'aws_vpc_security_group_egress_rule'." This reverts commit cde1055.

Use embedded struct function pointers for specialization.

f55eb6c

github-actions bot added documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. labels Feb 17, 2023

Correct CHANGELOG file name.

ddd44d1

github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Feb 17, 2023

ewbankkit mentioned this pull request Feb 17, 2023

[Enhancement]: Import aws_security_group_rule via Security Group Rule ID #29404

Closed

ewbankkit added the new-resource Introduces a new resource. label Feb 17, 2023

This comment was marked as outdated.

Sign in to view

ewbankkit added 3 commits February 17, 2023 16:23

Fix markdown-lint 'MD047/single-trailing-newline Files should end wit…

27dae26

…h a single newline character'.

Fix misspell 'prefered is a misspelling of preferred'.

540a446

Fix generate/checknames error.

b92238e

ewbankkit mentioned this pull request Feb 21, 2023

Don't do anything for Framework tags_all plan modification on Delete #29550

Merged

ewbankkit added 2 commits February 21, 2023 11:25

Start on some documentation about all the different SG Rule resources.

59c2d01

Documentation tweaks.

f7621d2

github-actions bot added github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Feb 21, 2023

ewbankkit added 3 commits February 21, 2023 13:11

Further refinements.

fb6d60b

d/aws_vpc_security_group_rules: New data source.

51468d9

ewbankkit added the new-data-source Introduces a new data source. label Feb 21, 2023

github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 21, 2023

github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Feb 21, 2023

ewbankkit force-pushed the f-aws_vpc_security_group_rule-enable branch from cd63dd1 to 2578217 Compare February 21, 2023 22:28

ewbankkit added 3 commits February 21, 2023 17:31

Fix markdown-lint 'MD047/single-trailing-newline Files should end wit…

39dccc7

…h a single newline character'.

Don't send an empty filters list; the EC2 API won't accept it.

6d82b68

Complete Security Group Rule documentation.

aa01346

ewbankkit marked this pull request as ready for review February 22, 2023 13:37

ewbankkit merged commit 12cc933 into main Feb 22, 2023

ewbankkit deleted the f-aws_vpc_security_group_rule-enable branch February 22, 2023 20:24

github-actions bot added this to the v4.56.0 milestone Feb 22, 2023

github-actions bot pushed a commit that referenced this pull request Feb 22, 2023

Update CHANGELOG.md for #29484

b8f445b

rirze mentioned this pull request Mar 1, 2023

Support for new AWS resources aws_vpc_security_group_ingress_rule and aws_vpc_security_group_egress_rule snyk/driftctl#1636

Open

github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable new VPC Security Group Rule resources #29484

Enable new VPC Security Group Rule resources #29484

ewbankkit commented Feb 17, 2023 •

edited

Loading

github-actions bot commented Feb 17, 2023

This comment was marked as outdated.

github-actions bot commented Feb 24, 2023

github-actions bot commented Mar 27, 2023

Enable new VPC Security Group Rule resources #29484

Enable new VPC Security Group Rule resources #29484

Conversation

ewbankkit commented Feb 17, 2023 • edited Loading

Description

Relations

Output from Acceptance Testing

github-actions bot commented Feb 17, 2023

Community Note

This comment was marked as outdated.

github-actions bot commented Feb 24, 2023

github-actions bot commented Mar 27, 2023

ewbankkit commented Feb 17, 2023 •

edited

Loading