Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_glue_job: add support for job run queuing #39027

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

mahadzaryab1
Copy link
Contributor

Description

  • Added support for job run queuing to the AWS Glue Job resource

Relations

Closes #38991

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner August 25, 2024 00:42
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/glue Issues and PRs that pertain to the glue service. needs-triage Waiting for first response or review from a maintainer. labels Aug 25, 2024
@jar-b jar-b added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 26, 2024
jar-b added 4 commits August 29, 2024 10:33
```console
% make testacc PKG=glue TESTS=TestAccGlueJob_jobRunQueuingEnabled
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_jobRunQueuingEnabled'  -timeout 360m

--- PASS: TestAccGlueJob_jobRunQueuingEnabled (21.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       27.816s
```
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=glue TESTS=TestAccGlueJob_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_'  -timeout 360m

--- PASS: TestAccGlueJob_maintenanceWindow (38.74s)
=== CONT  TestAccGlueJob_disappears
--- PASS: TestAccGlueJob_rayJob (38.78s)
=== CONT  TestAccGlueJob_glueVersion
--- PASS: TestAccGlueJob_basicStreaming (39.09s)
--- PASS: TestAccGlueJob_basic (40.87s)
--- PASS: TestAccGlueJob_command (60.48s)
--- PASS: TestAccGlueJob_defaultArguments (60.63s)
--- PASS: TestAccGlueJob_streamingTimeout (60.87s)
--- PASS: TestAccGlueJob_jobRunQueuingEnabled (62.62s)
--- PASS: TestAccGlueJob_executionProperty (63.78s)
--- PASS: TestAccGlueJob_security (63.87s)
--- PASS: TestAccGlueJob_timeout (64.00s)
--- PASS: TestAccGlueJob_maxCapacity (64.02s)
--- PASS: TestAccGlueJob_nonOverridableArguments (64.06s)
--- PASS: TestAccGlueJob_notificationProperty (64.08s)
--- PASS: TestAccGlueJob_executionClass (64.10s)
--- PASS: TestAccGlueJob_description (64.15s)
--- PASS: TestAccGlueJob_maxRetries (64.17s)
--- PASS: TestAccGlueJob_disappears (26.35s)
--- PASS: TestAccGlueJob_tags (71.30s)
--- PASS: TestAccGlueJob_pythonShell (79.87s)
--- PASS: TestAccGlueJob_glueVersion (44.89s)
--- PASS: TestAccGlueJob_workerType (85.67s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       91.732s

@jar-b
Copy link
Member

jar-b commented Aug 29, 2024

Thanks for your contribution, @mahadzaryab1! 👍

@jar-b jar-b merged commit f0ef6d9 into hashicorp:main Aug 29, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.65.0 milestone Aug 29, 2024
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: r/aws_glue_job: Add support for job run queuing
2 participants