Added virtual_network_rules for cosmosDB_account #1959
Conversation
| Default: false, | ||
| }, | ||
|
|
||
| "virtual_network_rules": { |
There was a problem hiding this comment.
as discussed this could be simpler:
"virtual_network_rule_subnet_ids": {
Type: schema.TypeSet,
Optional: true,
Elem: &schema.Schema{Type: schema.TypeString},
Set: schema.HashString,
}There was a problem hiding this comment.
I tried that and it didn't work, I can try again...
| @@ -335,6 +358,7 @@ func resourceArmCosmosDBAccountUpdate(d *schema.ResourceData, meta interface{}) | |||
| client := meta.(*ArmClient).cosmosDBClient | |||
| ctx := meta.(*ArmClient).StopContext | |||
| log.Printf("[INFO] preparing arguments for AzureRM Cosmos DB Account update.") | |||
| log.Printf("[INFO] AzureRM Cosmos DB Account : %s", d) | |||
There was a problem hiding this comment.
Could we merge these two log statements?
| is_virtual_network_filter_enabled = true | ||
|
|
||
| virtual_network_rules { | ||
| id = "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cosmosDBVNetRules/providers/Microsoft.Network/virtualNetworks/virtualNetwork1/subnets/testsubnet1" |
There was a problem hiding this comment.
Could we use ${subnet.example.id} instead of an explicit id?
|
Looks like we raced to this: I've just opened #1961 to the same effect. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Added
is_virtual_network_filterandvirtual_network_rules(Fixes #1342 )