New Resource: azurerm_site_recovery_vmware_replication_policy_classic

[ziyeqf]

test

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/recoveryservices -run=TestAccSiteRecoveryReplicationPolicyV2A -timeout=600m
=== RUN   TestAccSiteRecoveryReplicationPolicyV2A_basic
=== PAUSE TestAccSiteRecoveryReplicationPolicyV2A_basic
=== RUN   TestAccSiteRecoveryReplicationPolicyV2A_noSnapshots
=== PAUSE TestAccSiteRecoveryReplicationPolicyV2A_noSnapshots
=== RUN   TestAccSiteRecoveryReplicationPolicyV2A_wrongSettings
=== PAUSE TestAccSiteRecoveryReplicationPolicyV2A_wrongSettings
=== CONT  TestAccSiteRecoveryReplicationPolicyV2A_basic
=== CONT  TestAccSiteRecoveryReplicationPolicyV2A_wrongSettings
=== CONT  TestAccSiteRecoveryReplicationPolicyV2A_noSnapshots
--- PASS: TestAccSiteRecoveryReplicationPolicyV2A_wrongSettings (14.40s)
--- PASS: TestAccSiteRecoveryReplicationPolicyV2A_noSnapshots (443.06s)
--- PASS: TestAccSiteRecoveryReplicationPolicyV2A_basic (623.56s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      623.630s

[tombuildsstuff]

@ziyeqf the Classic resources are likely to be removed in the future - since #20881 is adding support for the non-Classic version, what's the use-case for supporting the Classic version?

[ziyeqf]

@ziyeqf the Classic resources are likely to be removed in the future - since #20881 is adding support for the non-Classic version, what's the use-case for supporting the Classic version?

Users could also use it for now. And the applications used to connected VMWare to vault are different, the classic one has been released for more time (maybe more stable?) so there may be users want to use the classic version I think.

Another thing is once a Recovery Vault is set to classic mode, it will not be able to set back again. If users want to migrate their infra to Terraform, they might need this.

[tombuildsstuff]

@grayzu is reaching out to the Service Team about this one

[tombuildsstuff]

hey @ziyeqf

As discussed offline, since we're not planing to support the classic version of this resource, whilst I'd like to thank you for this PR @ziyeqf I'm going to close this PR for the moment.

Thanks!

[grayzu]

@tombuildsstuff actually this PR is in support of new functionality. The classic name might be misleading here but this should not fall into the same bucket as other classic resources. Reopening and will discuss further offline if necessary.

[ziyeqf]

Sorry for the forth and back, discussed offline we decided to close this PR