Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_log_profile - mark as deprecated #23146

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Sep 1, 2023

from https://learn.microsoft.com/en-us/azure/azure-monitor/essentials/activity-log?tabs=powershell#legacy-collection-methods

On 30 September 2026, the legacy solution for forwarding Azure activity logs, known as Log Profiles, will be retired and replaced with diagnostic settings. This transition to diagnostic settings will happen automatically—you don’t need to take any action, and the change won’t cause any disruption in your workflow.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @teowa

Thanks for this PR - I've taken a look through and left some comments inline, but if we can fix those up then this otherwise should be good to go 👍

Thanks!

internal/services/monitor/monitor_log_profile_resource.go Outdated Show resolved Hide resolved
website/docs/d/monitor_log_profile.html.markdown Outdated Show resolved Hide resolved
website/docs/r/monitor_log_profile.html.markdown Outdated Show resolved Hide resolved
internal/services/monitor/monitor_log_profile_resource.go Outdated Show resolved Hide resolved
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teowa LGTM 👍

@stephybun stephybun merged commit 7e928d0 into hashicorp:main Sep 6, 2023
23 checks passed
@github-actions github-actions bot added this to the v3.72.0 milestone Sep 6, 2023
stephybun added a commit that referenced this pull request Sep 7, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants