-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_batch_pool
- add new property accelerated_networking_enabled
#23160
Conversation
acceleratedNetworkingEnabled := false | ||
if input.EnableAcceleratedNetworking != nil && *input.EnableAcceleratedNetworking { | ||
acceleratedNetworkingEnabled = true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it defaults to false we can use the pointer.From function further down and get rid of this
acceleratedNetworkingEnabled := false | |
if input.EnableAcceleratedNetworking != nil && *input.EnableAcceleratedNetworking { | |
acceleratedNetworkingEnabled = true | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
Co-authored-by: stephybun <steph@hashicorp.com>
Testing evidence after the change. Testing results on datasource is TBD.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liuwuliuyun LGTM 👍
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
azurerm_batch_pool
accelerated_networking_enabled
Required
fromsubnet_id
Testing evidence:
The failed one is not due to this PR and I will try to fix that in a new one.