-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_api_management_api_version_set
#3073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @metacpp
Thanks for this PR :)
I've taken a look through and left some comments inline but this is off to a good start. If we can fix up the comments and the tests pass then we should be able to get this merged.
Thanks!
State: schema.ImportStatePassthrough, | ||
}, | ||
|
||
CustomizeDiff: func(diff *schema.ResourceDiff, v interface{}) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since these fields are likely to be Interpolated, unfortunately we're unable to use a CustomizeDiff here; as such we'll need to remove this and instead put it in the Create method for the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I can move it to CreateOrUpdate method, but I still don't quite understand the principle here. Do you know why the CustomDiff
in AKS a is different than what you suggested here ?
78000b2
to
87fd7b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @metacpp
Thanks for pushing those commits to fix some of the comments - so that we can get this shipped in v1.24 (which will be going out shortly) I'm going to push a couple of commits to resolve the remaining issues, I hope you don't mind!
Thanks!
This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.24.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
This PR is to add
azurerm_api_management_api_version_set
resource to better supportazurerm_api_management_api
resource.