Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_api_management_api_version_set #3073

Merged
merged 11 commits into from
Apr 3, 2019

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Mar 19, 2019

This PR is to add azurerm_api_management_api_version_set resource to better support azurerm_api_management_api resource.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @metacpp

Thanks for this PR :)

I've taken a look through and left some comments inline but this is off to a good start. If we can fix up the comments and the tests pass then we should be able to get this merged.

Thanks!

State: schema.ImportStatePassthrough,
},

CustomizeDiff: func(diff *schema.ResourceDiff, v interface{}) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since these fields are likely to be Interpolated, unfortunately we're unable to use a CustomizeDiff here; as such we'll need to remove this and instead put it in the Create method for the moment

Copy link
Contributor Author

@metacpp metacpp Apr 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I can move it to CreateOrUpdate method, but I still don't quite understand the principle here. Do you know why the CustomDiff in AKS a is different than what you suggested here ?

azurerm/resource_arm_api_management_api_version_set.go Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_api_version_set.go Outdated Show resolved Hide resolved
azurerm/resource_arm_api_management_api_version_set.go Outdated Show resolved Hide resolved
@metacpp
Copy link
Contributor Author

metacpp commented Apr 2, 2019

The PR has been updated and tests all passed:
image

@metacpp metacpp modified the milestone: v1.25.0 Apr 2, 2019
@tombuildsstuff tombuildsstuff added this to the v1.24.0 milestone Apr 3, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @metacpp

Thanks for pushing those commits to fix some of the comments - so that we can get this shipped in v1.24 (which will be going out shortly) I'm going to push a couple of commits to resolve the remaining issues, I hope you don't mind!

Thanks!

@tombuildsstuff
Copy link
Contributor

Tests pass with the updated code:

Screenshot 2019-04-03 at 15 33 28

@tombuildsstuff tombuildsstuff merged commit abd97e9 into master Apr 3, 2019
@tombuildsstuff tombuildsstuff deleted the working/apim-apivs branch April 3, 2019 13:34
tombuildsstuff added a commit that referenced this pull request Apr 3, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

This has been released in version 1.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
	version = "~> 1.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants