New Resource: azurerm_container_registry_webhook

[r0bnet]

Implementation of a Container Registry Webhook.

Was requested here: #4067

(fixes #4067)

[katbyte]

Thank you for the PR @r0bnet,

Overall this is looking great, in addition to a couple minor comments i've left inline i'm seeing a test failure:

------- Stdout: -------
=== RUN   TestAccAzureRMContainerRegistryWebhook_Actions
=== PAUSE TestAccAzureRMContainerRegistryWebhook_Actions
=== CONT  TestAccAzureRMContainerRegistryWebhook_Actions
--- FAIL: TestAccAzureRMContainerRegistryWebhook_Actions (98.84s)
    testing.go:568: Step 0 error: Check failed: Check 3/3 error: azurerm_container_registry_webhook.test: Attribute 'actions.0' not found
FAIL

[r0bnet]

Hey @katbyte
thought i executed the test locally but seems like i skipped it somehow. Was wrong because actions is a set. Fixed the test accordingly. Should be fine now :)

[katbyte]

Thanks @r0bnet!

I hope you don't mind but i've swapped over to explicitly use constants. We avoid using the auto generated lists as sometimes the azure SDK drops support for them randomly and that could potentially break people. this way we know if a new SDK version drops it and can investigate if its valid or not.

LGTM now 👍

[ghost]

This has been released in version 1.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.33.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!