Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_network_security_rule & azurerm_network_security_rule - add support for Icmp to the protocol property #4615

Merged
merged 4 commits into from
Oct 17, 2019
Merged

azurerm_network_security_rule & azurerm_network_security_rule - add support for Icmp to the protocol property #4615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5245328
Added Icmp to NSG Rule Protocol validation + test
Oct 14, 2019
bd8b44c
Fixed line ending mistake
Oct 14, 2019
bbe5828
Added validation for security rule
Oct 15, 2019
8bb8a4a
Updated docs
Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions azurerm/resource_arm_network_security_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func resourceArmNetworkSecurityGroup() *schema.Resource {
string(network.SecurityRuleProtocolAsterisk),
string(network.SecurityRuleProtocolTCP),
string(network.SecurityRuleProtocolUDP),
string(network.SecurityRuleProtocolIcmp),
}, true),
DiffSuppressFunc: suppress.CaseDifference,
},
Expand Down
1 change: 1 addition & 0 deletions azurerm/resource_arm_network_security_rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ func resourceArmNetworkSecurityRule() *schema.Resource {
string(network.SecurityRuleProtocolAsterisk),
string(network.SecurityRuleProtocolTCP),
string(network.SecurityRuleProtocolUDP),
string(network.SecurityRuleProtocolIcmp),
}, true),
DiffSuppressFunc: suppress.CaseDifference,
},
Expand Down
2 changes: 1 addition & 1 deletion azurerm/resource_arm_network_security_rule_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ resource "azurerm_network_security_rule" "test2" {
priority = 101
direction = "Inbound"
access = "Deny"
protocol = "Tcp"
protocol = "Icmp"
source_port_range = "*"
destination_port_range = "*"
source_address_prefix = "*"
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/network_security_group.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ Elements of `security_rule` support:

* `description` - (Optional) A description for this rule. Restricted to 140 characters.

* `protocol` - (Required) Network protocol this rule applies to. Can be `Tcp`, `Udp` or `*` to match both.
* `protocol` - (Required) Network protocol this rule applies to. Can be `Tcp`, `Udp`, `Icmp`, or `*` to match all.

* `source_port_range` - (Optional) Source Port or Range. Integer or range between `0` and `65535` or `*` to match any. This is required if `source_port_ranges` is not specified.

Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/network_security_rule.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ The following arguments are supported:

* `description` - (Optional) A description for this rule. Restricted to 140 characters.

* `protocol` - (Required) Network protocol this rule applies to. Possible values include `Tcp`, `Udp` or `*` (which matches both).
* `protocol` - (Required) Network protocol this rule applies to. Possible values include `Tcp`, `Udp`, `Icmp`, or `*` (which matches all).

* `source_port_range` - (Optional) Source Port or Range. Integer or range between `0` and `65535` or `*` to match any. This is required if `source_port_ranges` is not specified.

Expand Down