Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue of missing subcategory attribute for md file #4887

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Nov 15, 2019

Currently the travis ci pipeline is failed due to missing the property subcategory in md file. So this fix is trying to resolve this issue. Thanks.

The failed travis ci:
https://travis-ci.org/terraform-providers/terraform-provider-azurerm/jobs/612147960?utm_medium=notification&utm_source=github_status

@neil-yechenwei
Copy link
Contributor Author

@katbyte , I just found it seems that the check logic of md file has been changed, which requires the property subcategory in md file so that the travis ci is failed. So I submitted this pr to fix this issue. Thanks.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @neil-yechenwei

Thanks for this PR.

If we can add a name for the category rather than just having an empty value then this otherwise LGTM.

Thanks!

website/docs/d/netapp_account.html.markdown Outdated Show resolved Hide resolved
website/docs/r/netapp_account.html.markdown Outdated Show resolved Hide resolved
@neil-yechenwei
Copy link
Contributor Author

@tombuildsstuff , Thanks for you comment. I've updated code.

@tombuildsstuff tombuildsstuff added this to the v1.37.0 milestone Nov 15, 2019
@tombuildsstuff tombuildsstuff merged commit 346ba91 into hashicorp:master Nov 15, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants