-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend/azurerm: support for authenticating via SAS Tokens #19440
Conversation
ed2362a
to
89fdfd8
Compare
89fdfd8
to
9ef35b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Feel free to leave the defer
stuff as is, if you prefer.
Ignoring the known failing tests (which are fixed by #19441) - the tests otherwise look good: |
Is possible to get a working example for that in .tf style? terraform {
backend "azurerm" {
sas_token = "xxx"
}
} Does it aim at the SAS token for the container ( |
I see this PR was merged before tf v0.11.11 was built but sas_token doesn't seem to be supported? |
@abelal83 unfortunately this PR is not included in v0.11.11 - it will ship as a part of Terraform 0.12 |
Is it in the current alpha? |
That's great to hear @tombuildsstuff |
@ps23 don't think it is. I had a look at the build artifacts and sas key support didn't make it in. |
@ps23 it appears this shipped in Terraform 0.12 Alpha 3 (and later): https://github.com/hashicorp/terraform/blob/master/CHANGELOG.md#0120-alpha3-december-6-2018 |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This PR adds support for authenticating using a SAS Token, which allows limited access permissions to be used to access a Storage Account.
Needs to be merged after #19433