Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get-plugins flag #27463

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Remove get-plugins flag #27463

merged 2 commits into from
Jan 11, 2021

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Jan 11, 2021

Remove the no-op get-plugins flag, this follows through on a deprecation notice released in the 0.14 series.

Remove the no-op get-plugins flag
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #27463 (e22ccd4) into master (aab0dd1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
command/init.go 61.95% <100.00%> (+0.29%) ⬆️
states/statefile/version4.go 58.19% <0.00%> (+0.23%) ⬆️
dag/marshal.go 63.49% <0.00%> (+1.58%) ⬆️
communicator/communicator.go 80.70% <0.00%> (+3.50%) ⬆️

@pselle pselle requested a review from a team January 11, 2021 17:00
Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also update the website, but that doesn't need to happen in this PR: https://www.terraform.io/docs/commands/init.html#get-plugins-false

@pselle
Copy link
Contributor Author

pselle commented Jan 11, 2021

@mildwonkey Oops, yes I want to update that call-out block there too. Will update that here so it's all together.

@pselle pselle merged commit 0d87c66 into master Jan 11, 2021
@pselle pselle deleted the pselle/get-plugins branch January 11, 2021 20:02
@ghost
Copy link

ghost commented Feb 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants