Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of core: Add sensitive provider attrs to JSON plan into v0.15 #28542

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #28523 to be assessed for backporting due to the inclusion of the label 0.15-backport.

The below text is copied from the body of the original PR.


When rendering a stored plan file as JSON, we include a data structure representing the sensitivity of the changed resource values (#28201). Prior to this commit, this was a direct representation of the sensitivity marks applied to values via mechanisms such as sensitive variables, sensitive outputs, and the sensitive function.

This commit extends this to include sensitivity based on the provider schema. This is in line with the UI rendering of the plan, which considers these two different types of sensitivity to be equivalent.

Fixes #28522.

@teamterraform teamterraform force-pushed the backport/alisdair/json-plan-sensitive-provider-attrs/instantly-blessed-macaw branch from 4aaefdd to e403444 Compare April 28, 2021 19:50
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #28542 (e403444) into v0.15 (b808170) will decrease coverage by 0.01%.
The diff coverage is 62.16%.

Impacted Files Coverage Δ
command/jsonplan/plan.go 33.33% <0.00%> (-0.72%) ⬇️
configs/configschema/marks.go 77.77% <77.77%> (ø)
terraform/evaluate.go 50.86% <100.00%> (-2.32%) ⬇️
terraform/node_resource_plan.go 96.11% <0.00%> (-1.95%) ⬇️
dag/marshal.go 63.49% <0.00%> (+1.58%) ⬆️
configs/configschema/implied_type.go 86.48% <0.00%> (+5.40%) ⬆️

@alisdair alisdair merged commit d0e0fbb into v0.15 Apr 28, 2021
@alisdair alisdair deleted the backport/alisdair/json-plan-sensitive-provider-attrs/instantly-blessed-macaw branch April 28, 2021 19:55
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants