update golang.org/x/crypto again #31092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The version that was in use previously broke my runs with a nice `ssh: handshake failed: agent unsupported algorithm "ssh-ed25519"` error. I took a further look into this, and saw that the change that broke ssh for me was fixed in golang/crypto@46612604a. Yay!
jbardin
added
the
1.2-backport
|
Thanks for digging into this @nilsding! |
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version that was in use previously broke my runs using ssh-agent with a signed ed25519 key with a nice
ssh: handshake failed: agent unsupported algorithm "ssh-ed25519"error. I took a further look into this, and saw that the upstream change that broke it for me was fixed in golang/crypto@46612604a -- therefore I just updated this dependency again to the (as the time of writing) latest version.If possible this change needs a backport to terraform 1.2, as this is the version I tried to use ...