Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix no-op outputs causing the plan renderer to skip the 'no changes' message into v1.4 #32822

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #32820 to be assessed for backporting due to the inclusion of the label 1.4-backport.

The below text is copied from the body of the original PR.


Currently, we are checking whether the output changes are empty before deciding to print the "no changes" message in the renderer. But, no-op changes do not print anything so any plan with no-op changes will make the renderer consider the output changes to be not empty so it won't print the nice message but then it also won't print any outputs.

This PR fixes this by computing the concrete output diffs earlier and then using them to decide whether to print the "no changes" message.

Fixes #32815

Target Release

1.4.1

Draft CHANGELOG entry

BUG FIXES

  • Fix the plan renderer skipping the "no changes" messages when there are no-op outputs within the plan.

@teamterraform teamterraform force-pushed the backport/liamcervante/32815/weekly-saving-stinkbug branch from 2a9df21 to 42b5060 Compare March 10, 2023 15:20
@teamterraform teamterraform force-pushed the backport/liamcervante/32815/weekly-saving-stinkbug branch from 97d77a0 to 4faca62 Compare March 10, 2023 15:20
@liamcervante liamcervante merged commit 7395cf9 into v1.4 Mar 10, 2023
@liamcervante liamcervante deleted the backport/liamcervante/32815/weekly-saving-stinkbug branch March 10, 2023 15:35
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants