Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stackruntime: Support referencing Local Values within the tfstacks.hcl language #34797

Merged
merged 11 commits into from
Jun 20, 2024

Conversation

mutahhir
Copy link
Member

@mutahhir mutahhir commented Mar 8, 2024

Local Values are made available in the .tfstack.hcl language. The existing codebase already had support for local values, it was incomplete was missing the machinery required to reference local values within the tfstacks.hcl files.

Target Release

1.8.x

@mutahhir mutahhir marked this pull request as ready for review March 13, 2024 11:07
@mutahhir mutahhir requested a review from a team March 13, 2024 11:09
Copy link
Contributor

@apparentlymart apparentlymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

My comments inline are mostly just little details that I don't think affect the end-user-visible behavior, but might make things clearer for the next maintainer.

Copy link
Collaborator

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, I feel like the test cases cover enough ground 👍

@mutahhir mutahhir merged commit 01c5dda into main Jun 20, 2024
6 checks passed
@mutahhir mutahhir deleted the mutahhir/stacks/local-value branch June 20, 2024 12:44
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants