-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stackruntime: Support referencing Local Values within the tfstacks.hcl
language
#34797
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
My comments inline are mostly just little details that I don't think affect the end-user-visible behavior, but might make things clearer for the next maintainer.
internal/stacks/stackruntime/internal/stackeval/local_value_config.go
Outdated
Show resolved
Hide resolved
internal/stacks/stackruntime/internal/stackeval/local_value_config.go
Outdated
Show resolved
Hide resolved
internal/stacks/stackruntime/internal/stackeval/local_value_test.go
Outdated
Show resolved
Hide resolved
internal/stacks/stackruntime/internal/stackeval/planning_test.go
Outdated
Show resolved
Hide resolved
...e/internal/stackeval/testdata/sourcebundle/local_value/basics/local-value-basics.tfstack.hcl
Show resolved
Hide resolved
8fe8d94
to
6bbc8cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, I feel like the test cases cover enough ground 👍
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Local Values are made available in the .tfstack.hcl language. The existing codebase already had support for local values, it was incomplete was missing the machinery required to reference local values within the
tfstacks.hcl
files.Target Release
1.8.x