Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for partial addresses and targets that start with 'resource.' #35333

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

liamcervante
Copy link
Member

This PR fixes a potential bug where resource addresses that start with resource. could not be parsed as partial addresses or targets. This is unlikely to ever be encountered because the resource. prefix is entirely optional, but still valid so we should support it.

Target Release

1.9.0

Draft CHANGELOG entry

BUG FIXES

  • Fixes case where resource addresses that start with resource. could not be parsed as targets.

@liamcervante liamcervante requested a review from a team June 12, 2024 12:01
@liamcervante liamcervante added the 1.9-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jun 12, 2024
@liamcervante liamcervante merged commit 55600d8 into main Jun 14, 2024
6 checks passed
@liamcervante liamcervante deleted the liamcervante/include-resource-prefix branch June 14, 2024 07:58
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.9-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants