stacks: apply nested default values to inputs #35349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
approved these changes
Jun 17, 2024
| } | ||
|
|
||
| // TODO: check the value against any custom validation rules |
There was a problem hiding this comment.
There is a TODO left, is this meant for this PR?
There was a problem hiding this comment.
No, this is about responding to custom validation rules on the inputs. We're not doing that at the moment (for any of the execution paths).
…te/stacks/defaults
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some additional test cases around default values for input variables into stacks, components, and embedded stacks. The tests found that root stack variables were not applying default values and this has been fixed.
This PR also adds some extra helper functions for parsing addresses in test files. As part of that the address parsing functions have been refactored to support parsing both component and resource addresses.
Internal ticket: TF-10860