Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect example in the docs #35364

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix incorrect example in the docs #35364

merged 1 commit into from
Jun 24, 2024

Conversation

sehyod
Copy link
Contributor

@sehyod sehyod commented Jun 20, 2024

The example given to illustrate the behaviour of logical operators is incorrect. var.foo || var.foo.bar would also produce an error if the operator was short-circuiting. The example should be with var.foo && var.foo.bar, that produces an error in terraform, but wouldn't if && was short-circuiting.

The example given to illustrate the behaviour of logical operators is incorrect.
`var.foo || var.foo.bar` would also produce an error if the operator  was short-circuiting. The example should be with `var.foo && var.foo.bar`, that produces an error in terraform, but wouldn't if `||` could short-circuit
Copy link

hashicorp-cla-app bot commented Jun 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@crw
Copy link
Collaborator

crw commented Jun 20, 2024

Thanks for this submission, we will review in triage.

@crw crw added the 1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jun 24, 2024
@crw crw merged commit af498dd into hashicorp:main Jun 24, 2024
6 of 7 checks passed
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@sehyod sehyod deleted the patch-1 branch July 10, 2024 13:20
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants