Skip to content

Delay extension registration (hence Lambda runtime initialization) un… #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Delay extension registration (hence Lambda runtime initialization) un… #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84eaa35
Delay extension registration (hence Lambda runtime initialization) un…
JinlianWang Feb 28, 2022
44c998d
Merge branch 'main' into Issue31Fixing
tomhjp Apr 1, 2022
6f86db6
Add changelog note
tomhjp Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## Unreleased

CHANGES:

* Static function code can now reliably read secrets written to disk, because extension registration now occurs after writing files. [[GH-61](https://github.com/hashicorp/vault-lambda-extension/pull/61)]

## 0.6.0 (March 14, 2022)

CHANGES:
Expand Down
12 changes: 6 additions & 6 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,6 @@ func realMain(logger hclog.Logger) error {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()

extensionClient := extension.NewClient(os.Getenv("AWS_LAMBDA_RUNTIME_API"))
_, err := extensionClient.Register(ctx, extensionName)
if err != nil {
return err
}

var wg sync.WaitGroup
srv, err := runExtension(ctx, logger, &wg)
if err != nil {
Expand All @@ -78,6 +72,12 @@ func realMain(logger hclog.Logger) error {
}
}()

extensionClient := extension.NewClient(os.Getenv("AWS_LAMBDA_RUNTIME_API"))
_, err = extensionClient.Register(ctx, extensionName)
if err != nil {
return err
}

processEvents(ctx, logger, extensionClient)

// Once processEvents returns, signal that it's time to shutdown.
Expand Down